Issue 12637025: DateField cache should check the ExternalOperand instead of ExternalReference on X64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12637025: DateField cache should check the ExternalOperand instead of ExternalReference on X64 (Closed)

Created:
7 years, 9 months ago by weiliang.lin2

Modified:
7 years, 9 months ago

Reviewers:
Yang, Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

DateField cache should check the ExternalOperand instead of ExternalReference on X64 Committed: https://code.google.com/p/v8/source/detail?r=13919

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/x64/full-codegen-x64.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Yang

Committed patchset #1 manually as r13919 (presubmit successful).

7 years, 9 months ago (2013-03-13 09:28:14 UTC) #3

Yang

7 years, 9 months ago (2013-03-13 09:28:47 UTC) #4

Message was sent while issue was closed.

On 2013/03/13 09:09:58, Yang wrote:
> On 2013/03/12 03:36:14, weiliang.lin2 wrote:
> 
> LGTM.

This indeed improves performance on x64. Thanks!