Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 12637025: DateField cache should check the ExternalOperand instead of ExternalReference on X64 (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1625 matching lines...) Expand 10 before | Expand all | Expand 10 after
1636 Condition cc = masm()->CheckSmi(object); 1636 Condition cc = masm()->CheckSmi(object);
1637 DeoptimizeIf(cc, instr->environment()); 1637 DeoptimizeIf(cc, instr->environment());
1638 __ CmpObjectType(object, JS_DATE_TYPE, kScratchRegister); 1638 __ CmpObjectType(object, JS_DATE_TYPE, kScratchRegister);
1639 DeoptimizeIf(not_equal, instr->environment()); 1639 DeoptimizeIf(not_equal, instr->environment());
1640 1640
1641 if (index->value() == 0) { 1641 if (index->value() == 0) {
1642 __ movq(result, FieldOperand(object, JSDate::kValueOffset)); 1642 __ movq(result, FieldOperand(object, JSDate::kValueOffset));
1643 } else { 1643 } else {
1644 if (index->value() < JSDate::kFirstUncachedField) { 1644 if (index->value() < JSDate::kFirstUncachedField) {
1645 ExternalReference stamp = ExternalReference::date_cache_stamp(isolate()); 1645 ExternalReference stamp = ExternalReference::date_cache_stamp(isolate());
1646 __ movq(kScratchRegister, stamp); 1646 Operand stamp_operand = __ ExternalOperand(stamp);
1647 __ movq(kScratchRegister, stamp_operand);
1647 __ cmpq(kScratchRegister, FieldOperand(object, 1648 __ cmpq(kScratchRegister, FieldOperand(object,
1648 JSDate::kCacheStampOffset)); 1649 JSDate::kCacheStampOffset));
1649 __ j(not_equal, &runtime, Label::kNear); 1650 __ j(not_equal, &runtime, Label::kNear);
1650 __ movq(result, FieldOperand(object, JSDate::kValueOffset + 1651 __ movq(result, FieldOperand(object, JSDate::kValueOffset +
1651 kPointerSize * index->value())); 1652 kPointerSize * index->value()));
1652 __ jmp(&done); 1653 __ jmp(&done);
1653 } 1654 }
1654 __ bind(&runtime); 1655 __ bind(&runtime);
1655 __ PrepareCallCFunction(2); 1656 __ PrepareCallCFunction(2);
1656 #ifdef _WIN64 1657 #ifdef _WIN64
(...skipping 4183 matching lines...) Expand 10 before | Expand all | Expand 10 after
5840 FixedArray::kHeaderSize - kPointerSize)); 5841 FixedArray::kHeaderSize - kPointerSize));
5841 __ bind(&done); 5842 __ bind(&done);
5842 } 5843 }
5843 5844
5844 5845
5845 #undef __ 5846 #undef __
5846 5847
5847 } } // namespace v8::internal 5848 } } // namespace v8::internal
5848 5849
5849 #endif // V8_TARGET_ARCH_X64 5850 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698