Switch Next Window Key functionality

Switch Next Window Key functionality

Switches the next window button on chromeos (f5) to act the same as alt-tab/shift-alt-tab


BUG=174035
TBR=sky@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190579

[Harry McCleave, 2013-03-21 03:04:00]

Ready for review, do we want to modify the keyboard shortcut screen thing
(ctrl+alt+/) to add descriptions to the button, it didn't have them before but
alt-tab has them?

[James Cook, 2013-03-21 16:10:02]

Also, Ctrl-Alt-/ has a description for the key "switch windows" which seems fine
to me

https://codereview.chromium.org/12618014/diff/2001/ash/accelerators/accelerat...
File ash/accelerators/accelerator_table.cc (right):

https://codereview.chromium.org/12618014/diff/2001/ash/accelerators/accelerat...
ash/accelerators/accelerator_table.cc:39: { true, ui::VKEY_MEDIA_LAUNCH_APP1,
ui::EF_NONE, CYCLE_FORWARD_MRU },
These need to be _LINEAR, not _MRU.  Otherwise you can't switch between all
three of three windows.  (This works for Alt-Tab because you can hold down the
Alt key and keep tapping to see them all.)

[Harry McCleave, 2013-03-22 04:19:55]

Mind taking another look when you get the chance, I think this is at least along
the lines of what we discussed.

[James Cook, 2013-03-22 16:45:36]

LGTM with two suggestions

https://codereview.chromium.org/12618014/diff/13002/ash/wm/window_cycle_contr...
File ash/wm/window_cycle_controller.cc (right):

https://codereview.chromium.org/12618014/diff/13002/ash/wm/window_cycle_contr...
ash/wm/window_cycle_controller.cc:158: windows_.reset(new
WindowCycleList(BuildWindowList(NULL, true)));
I would just make the WindowCycleList a local variable and inline the call to
Step().  It's a bit confusing to allocate windows_ and then immediately reset
it.

https://codereview.chromium.org/12618014/diff/13002/ash/wm/window_cycle_contr...
ash/wm/window_cycle_controller.cc:170: bool reverse_order) {
I would either change the sense of this boolean to "topmost_in_front", or keep
the current sense and call it "topmost_at_end"

[commit-bot: I haz the power, 2013-03-22 21:30:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/12618014/7018

[commit-bot: I haz the power, 2013-03-23 01:31:37]

Retried try job too often on linux_chromeos for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-03-25 20:09:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/12618014/37001

[commit-bot: I haz the power, 2013-03-26 06:55:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/12618014/37001

[commit-bot: I haz the power, 2013-03-26 07:43:29]

Change committed as 190579