Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1261693004: Allow dynamic enabling/disabling of unified desktop (Closed)

Created:
5 years, 4 months ago by oshima
Modified:
5 years, 4 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, sadrul, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow dynamic enabling/disabling of unified desktop The default multi display is stored in the layout store first, and which is used by UpdateDisplays later. Hence no need to update this layout information in WindowTreeHostManager. current_default_multi_display_mode_ is still necessary because it's also used when switching to/from mirror mode. This also fixed a bug in the logic to short ids. BUG=515607 TEST=covered by unittests. manual Committed: https://crrev.com/628a617979598ad6ade68cc7f48815477a2f903a Cr-Commit-Position: refs/heads/master@{#341452}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -148 lines) Patch
M ash/accelerators/accelerator_controller.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 1 chunk +51 lines, -43 lines 0 comments Download
M ash/accelerators/debug_commands.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ash/ash_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/display/display_layout.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/display_layout.cc View 4 chunks +9 lines, -3 lines 0 comments Download
M ash/display/display_layout_store.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/display/display_manager.h View 4 chunks +15 lines, -7 lines 0 comments Download
M ash/display/display_manager.cc View 1 9 chunks +36 lines, -21 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 6 chunks +26 lines, -10 lines 0 comments Download
M ash/display/display_util.h View 1 chunk +7 lines, -3 lines 0 comments Download
M ash/display/display_util.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M ash/display/display_util_unittest.cc View 1 chunk +20 lines, -4 lines 0 comments Download
M ash/display/unified_mouse_warp_controller_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/screen_util_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_display_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/test/display_manager_test_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/test/display_manager_test_api.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 35 (20 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261693004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261693004/60001
5 years, 4 months ago (2015-07-31 15:49:58 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/79920) linux_chromium_gn_chromeos_rel on ...
5 years, 4 months ago (2015-07-31 15:59:22 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261693004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261693004/80001
5 years, 4 months ago (2015-07-31 16:47:23 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/98634) linux_chromium_gn_rel on ...
5 years, 4 months ago (2015-07-31 17:03:49 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261693004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261693004/140001
5 years, 4 months ago (2015-07-31 22:53:30 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261693004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261693004/180001
5 years, 4 months ago (2015-07-31 23:12:30 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-31 23:50:04 UTC) #23
oshima
5 years, 4 months ago (2015-08-01 00:04:55 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261693004/180002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261693004/180002
5 years, 4 months ago (2015-08-01 00:05:29 UTC) #27
oshima
5 years, 4 months ago (2015-08-01 00:06:56 UTC) #28
Jun Mukai
lgtm
5 years, 4 months ago (2015-08-01 00:26:57 UTC) #29
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-01 01:13:40 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261693004/180002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261693004/180002
5 years, 4 months ago (2015-08-01 01:28:13 UTC) #33
commit-bot: I haz the power
Committed patchset #2 (id:180002)
5 years, 4 months ago (2015-08-01 01:33:34 UTC) #34
commit-bot: I haz the power
5 years, 4 months ago (2015-08-01 01:34:18 UTC) #35
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/628a617979598ad6ade68cc7f48815477a2f903a
Cr-Commit-Position: refs/heads/master@{#341452}

Powered by Google App Engine
This is Rietveld 408576698