Allow NaCl plugin to be loaded from hosted app URLs.

Allow NaCl plugin to be loaded from hosted app URLs.


A previous change blocked loading NaCl from non chrome-extension:
schemes. This broke NaCl functionality for hosted apps, which have
http: or https: URLs. This change fixes it.

BUG=181761
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188971

[meacer, 2013-03-12 21:49:36]

Please review. Thanks.

[Matt Perry, 2013-03-12 22:23:22]

https://codereview.chromium.org/12612011/diff/3001/chrome/renderer/chrome_con...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/12612011/diff/3001/chrome/renderer/chrome_con...
chrome/renderer/chrome_content_renderer_client.cc:552: if
(!is_invoked_by_hosted_app &&
I would pass |extension| as a parameter to IsNaclAllowed and move the
is_invoked_by_hosted_app check in there.

[meacer, 2013-03-14 21:51:43]

On 2013/03/12 22:23:22, Matt Perry wrote:
>
https://codereview.chromium.org/12612011/diff/3001/chrome/renderer/chrome_con...
> File chrome/renderer/chrome_content_renderer_client.cc (right):
> 
>
https://codereview.chromium.org/12612011/diff/3001/chrome/renderer/chrome_con...
> chrome/renderer/chrome_content_renderer_client.cc:552: if
> (!is_invoked_by_hosted_app &&
> I would pass |extension| as a parameter to IsNaclAllowed and move the
> is_invoked_by_hosted_app check in there.

Done, please see patch set 2.

[meacer, 2013-03-14 21:53:00]

On 2013/03/14 21:51:43, Mustafa Emre Acer wrote:
> On 2013/03/12 22:23:22, Matt Perry wrote:
> >
>
https://codereview.chromium.org/12612011/diff/3001/chrome/renderer/chrome_con...
> > File chrome/renderer/chrome_content_renderer_client.cc (right):
> > 
> >
>
https://codereview.chromium.org/12612011/diff/3001/chrome/renderer/chrome_con...
> > chrome/renderer/chrome_content_renderer_client.cc:552: if
> > (!is_invoked_by_hosted_app &&
> > I would pass |extension| as a parameter to IsNaclAllowed and move the
> > is_invoked_by_hosted_app check in there.
> 
> Done, please see patch set 2.

Sorry not 2, I meant the latest patch set.

[Matt Perry, 2013-03-14 21:57:33]

lgtm

[meacer, 2013-03-15 19:59:13]

On 2013/03/14 21:57:33, Matt Perry wrote:
> lgtm

Brett, please let me know if you had a chance to review this. I can find another
reviewer if you don't have the bandwidth. Thanks!

[Nick Bray (chromium), 2013-03-18 18:29:07]

This bug needs to get fixed.  I'd rather not keep dealing with the aftershocks. 
brettw, can you review it or explicitly take a pass?  meacer, would it make
sense to revert the previous CL if this one cannot be committed soon?

[brettw, 2013-03-18 19:48:01]

lgtm

[commit-bot: I haz the power, 2013-03-18 19:53:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/meacer@chromium.org/12612011/9001

[commit-bot: I haz the power, 2013-03-19 01:44:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/meacer@chromium.org/12612011/46001

[commit-bot: I haz the power, 2013-03-19 09:49:39]

Change committed as 188971