Allow NaCl plugin to be loaded from hosted app URLs.

chrome/renderer/chrome_content_renderer_client_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/utf_string_conversions.h"
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_builder.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
 #include "googleurl/src/gurl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebVector.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPluginParams.h"
 #include "webkit/plugins/webplugininfo.h"
 
 using WebKit::WebPluginParams;
 using WebKit::WebString;
 using WebKit::WebVector;
 using chrome::ChromeContentRendererClient;
 using webkit::WebPluginInfo;
 using webkit::WebPluginMimeType;
 
 namespace chrome {
 
 namespace {
 const bool kNaClRestricted = false;
 const bool kNaClUnrestricted = true;
 const bool kExtensionRestricted = false;
 const bool kExtensionUnrestricted = true;
 const bool kExtensionNotFromWebStore = false;
 const bool kExtensionFromWebStore = true;
+const bool kNotHostedApp = false;
+const bool kHostedApp = true;
 
 const char kNaClMimeType[] = "application/x-nacl";
 const char kExtensionUrl[] = "chrome-extension://extension_id/background.html";
 
 bool AllowsDevInterfaces(const WebPluginParams& params) {
   for (size_t i = 0; i < params.attributeNames.size(); ++i) {
     if (params.attributeNames[i] == WebString::fromUTF8("@dev"))
       return true;
   }
   return false;
@@ skipping 15 matching lines @@
   mime_type_info.mime_type = mime_type;
   mime_type_info.additional_param_names.push_back(UTF8ToUTF16("nacl"));
   mime_type_info.additional_param_values.push_back(
       UTF8ToUTF16(manifest_url));
   info->mime_types.push_back(mime_type_info);
 }
 }  // namespace
 
 typedef testing::Test ChromeContentRendererClientTest;
 
+
+scoped_refptr<const extensions::Extension> CreateTestExtension(
+    bool is_unrestricted, bool is_from_webstore, bool is_hosted_app,
+    const std::string& app_url) {
+  extensions::Manifest::Location location = is_unrestricted ?
+      extensions::Manifest::UNPACKED :
+      extensions::Manifest::INTERNAL;
+  int flags = is_from_webstore ?
+      extensions::Extension::FROM_WEBSTORE:
+      extensions::Extension::NO_FLAGS;
+
+  DictionaryValue manifest;
+  manifest.SetString("name", "NaCl Extension");
+  manifest.SetString("version", "1");
+  manifest.SetInteger("manifest_version", 2);
+  if (is_hosted_app) {
+    ListValue* url_list = new ListValue();
+    url_list->Append(Value::CreateStringValue(app_url));
+    manifest.Set(extension_manifest_keys::kWebURLs, url_list);
+    manifest.SetString(extension_manifest_keys::kLaunchWebURL, app_url);
+  }
+  std::string error;
+  return extensions::Extension::Create(base::FilePath(), location, manifest,
+                                       flags, &error);
+}
+
+scoped_refptr<const extensions::Extension> CreateExtension(
+    bool is_unrestricted, bool is_from_webstore) {
+  return CreateTestExtension(is_unrestricted, is_from_webstore, kNotHostedApp,
+                             "");
+}
+
+scoped_refptr<const extensions::Extension> CreateHostedApp(
+    bool is_unrestricted, bool is_from_webstore, const std::string& app_url) {
+  return CreateTestExtension(is_unrestricted, is_from_webstore, kHostedApp,
+                             app_url);
+}
+
 TEST_F(ChromeContentRendererClientTest, NaClRestriction) {
   // Unknown content types have no NaCl module.
   {
     WebPluginInfo info;
     EXPECT_EQ(GURL(),
               ChromeContentRendererClient::GetNaClContentHandlerURL(
                   "application/x-foo", info));
   }
   // Known content types have a NaCl module.
   {
     WebPluginInfo info;
     AddContentTypeHandler(&info, "application/x-foo", "www.foo.com");
     EXPECT_EQ(GURL("www.foo.com"),
               ChromeContentRendererClient::GetNaClContentHandlerURL(
                   "application/x-foo", info));
   }
   // --enable-nacl allows all NaCl apps, with 'dev' interfaces.
   {
     WebPluginParams params;
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
-        GURL(), GURL(), kNaClUnrestricted, kExtensionRestricted,
-        kExtensionNotFromWebStore, &params));
+        GURL(), GURL(), kNaClUnrestricted,
+        CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore),
+        &params));
     EXPECT_TRUE(AllowsDevInterfaces(params));
   }
   // Unrestricted extensions are allowed without --enable-nacl, with 'dev'
   // interfaces if called from an extension url.
   {
     WebPluginParams params;
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL(kExtensionUrl), kNaClRestricted,
-        kExtensionUnrestricted,
-        kExtensionNotFromWebStore, &params));
+        CreateExtension(kExtensionUnrestricted, kExtensionNotFromWebStore),
+        &params));
     EXPECT_TRUE(AllowsDevInterfaces(params));
   }
   // CWS extensions are allowed without --enable-nacl, without 'dev'
   // interfaces if called from an extension url.
   {
     WebPluginParams params;
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
-        GURL(), GURL(kExtensionUrl), kNaClRestricted, kExtensionRestricted,
-        kExtensionFromWebStore, &params));
+        GURL(), GURL(kExtensionUrl), kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionFromWebStore),
+        &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
   }
   // CWS extensions can't get 'dev' interfaces with --enable-nacl.
   {
     WebPluginParams params;
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
-        GURL(), GURL(kExtensionUrl), kNaClUnrestricted, kExtensionRestricted,
-        kExtensionFromWebStore, &params));
+        GURL(), GURL(kExtensionUrl), kNaClUnrestricted,
+        CreateExtension(kExtensionRestricted, kExtensionFromWebStore),
+        &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
   }
   // CWS extensions can't get 'dev' interfaces by injecting a fake
   // '@dev' attribute.
   {
     WebPluginParams params;
     AddFakeDevAttribute(&params);
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
-        GURL(), GURL(kExtensionUrl), kNaClRestricted, kExtensionRestricted,
-        kExtensionFromWebStore, &params));
+        GURL(), GURL(kExtensionUrl), kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionFromWebStore),
+        &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
   }
   // The NaCl PDF extension is allowed without --enable-nacl, with 'dev'
   // interfaces, from all URLs.
   {
     WebPluginParams params;
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
         GURL("chrome-extension://acadkphlmlegjaadjagenfimbpphcgnh"),
-        GURL(), kNaClRestricted, kExtensionRestricted,
-        kExtensionFromWebStore, &params));
+        GURL(), kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionFromWebStore),
+        &params));
     EXPECT_TRUE(AllowsDevInterfaces(params));
   }
   // Whitelisted URLs are allowed without --enable-nacl, without 'dev'
   // interfaces.
   {
     WebPluginParams params;
     EXPECT_FALSE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("http://plus.google.com/games"),
-        kNaClRestricted, kExtensionRestricted, kExtensionNotFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore),
         &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("https://plus.google.com/games"),
-        kNaClRestricted, kExtensionRestricted, kExtensionNotFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore),
         &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("https://plus.google.com/games/209089085730"),
-        kNaClRestricted, kExtensionRestricted, kExtensionNotFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore),
         &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
     EXPECT_FALSE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("http://plus.sandbox.google.com/games"),
-        kNaClRestricted, kExtensionRestricted, kExtensionNotFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore),
         &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("https://plus.sandbox.google.com/games"),
-        kNaClRestricted, kExtensionRestricted, kExtensionNotFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore),
         &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("https://plus.google.com/games/209089085730"),
-        kNaClRestricted, kExtensionRestricted, kExtensionNotFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore),
         &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
   }
   // Whitelisted URLs can't get 'dev' interfaces with --enable-nacl.
   {
     WebPluginParams params;
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("https://plus.google.com/games/209089085730"),
-        kNaClUnrestricted, kExtensionRestricted, kExtensionNotFromWebStore,
+        kNaClUnrestricted,
+        CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore),
         &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
   }
   // Whitelisted URLs can't get 'dev' interfaces by injecting a fake
   // '@dev' attribute.
   {
     WebPluginParams params;
     AddFakeDevAttribute(&params);
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("https://plus.google.com/games/209089085730"),
-        kNaClRestricted, kExtensionRestricted, kExtensionNotFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore),
         &params));
     EXPECT_FALSE(AllowsDevInterfaces(params));
   }
   // Non-whitelisted URLs are blocked without --enable-nacl.
   {
     WebPluginParams params;
     EXPECT_FALSE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("https://plus.google.com.evil.com/games1"),
-        kNaClRestricted, kExtensionRestricted, kExtensionNotFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore),
         &params));
     EXPECT_FALSE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("https://plus.google.com.evil.com/games2"),
-        kNaClRestricted, kExtensionRestricted, kExtensionFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionRestricted, kExtensionFromWebStore),
         &params));
     EXPECT_FALSE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("https://plus.google.com.evil.com/games3"),
-        kNaClRestricted, kExtensionUnrestricted, kExtensionNotFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionUnrestricted, kExtensionNotFromWebStore),
         &params));
     EXPECT_FALSE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(), GURL("https://plus.google.com.evil.com/games4"),
-        kNaClRestricted, kExtensionUnrestricted, kExtensionFromWebStore,
+        kNaClRestricted,
+        CreateExtension(kExtensionUnrestricted, kExtensionFromWebStore),
+        &params));
+  }
+  // Non chrome-extension:// URLs belonging to hosted apps are allowed.
+  {
+    WebPluginParams params;
+    EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
+        GURL(), GURL("http://example.com/test.html"),
+        kNaClRestricted,
+        CreateHostedApp(kExtensionRestricted, kExtensionNotFromWebStore,
+                        "http://example.com/"),
+        &params));
+    EXPECT_FALSE(ChromeContentRendererClient::IsNaClAllowed(
+        GURL(), GURL("http://example.evil.com/test.html"),
+        kNaClRestricted,
+        CreateHostedApp(kExtensionRestricted, kExtensionNotFromWebStore,
+                        "http://example.com/"),
         &params));
   }
 }
 
 }  // namespace chrome