Issue 12604023: Add test and fix for 9203, fix sdk dep, delete unused file.

Issue 12604023: Add test and fix for 9203, fix sdk dep, delete unused file. (Closed)

Created:
7 years, 9 months ago by Alan Knight

Modified:
7 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add test and fix for 9203, fix sdk dep, delete unused file. Committed: https://code.google.com/p/dart/source/detail?r=20346

Patch Set 2 : Fixes from review #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -309 lines)			Patch
M	pkg/pkg.status	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
D	pkg/serialization/lib/src/polyfill_identity_set.dart	View		1 chunk	+0 lines, -306 lines	0 comments	Download
M	pkg/serialization/lib/src/serialization_rule.dart	View		2 chunks	+4 lines, -2 lines	0 comments	Download
A	pkg/serialization/test/no_library_test.dart	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

This adds a test and provides a fix for serializing classes in a main program ...

7 years, 9 months ago (2013-03-18 20:44:35 UTC) #1

Jennifer Messerly

lgtm! https://chromiumcodereview.appspot.com/12604023/diff/1/pkg/serialization/pubspec.yaml File pkg/serialization/pubspec.yaml (right): https://chromiumcodereview.appspot.com/12604023/diff/1/pkg/serialization/pubspec.yaml#newcode8 pkg/serialization/pubspec.yaml:8: unittest: any this could be a dev_dependency? https://chromiumcodereview.appspot.com/12604023/diff/1/pkg/serialization/test/no_library_test.dart ...

7 years, 9 months ago (2013-03-21 00:32:38 UTC) #2

Alan Knight

https://chromiumcodereview.appspot.com/12604023/diff/1/pkg/serialization/pubspec.yaml File pkg/serialization/pubspec.yaml (right): https://chromiumcodereview.appspot.com/12604023/diff/1/pkg/serialization/pubspec.yaml#newcode8 pkg/serialization/pubspec.yaml:8: unittest: any On 2013/03/21 00:32:38, John Messerly wrote: > ...

7 years, 9 months ago (2013-03-21 20:39:25 UTC) #3

Alan Knight

7 years, 9 months ago (2013-03-21 20:40:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20346 (presubmit successful).

Expand Messages | Collapse Messages