Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 12601017: Remove forceLogin flag from sync setup. (Closed)

Created:
7 years, 9 months ago by jackhou1
Modified:
7 years, 8 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove forceLogin flag from sync setup. BUG=135620 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194845

Patch Set 1 #

Patch Set 2 : Sync and rebase #

Patch Set 3 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M chrome/browser/resources/sync_setup_overlay.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_browsertest.js View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jackhou1
Looks like someone removed the appNotifications stuff before I could https://chromiumcodereview.appspot.com/12680004, so this CL just ...
7 years, 9 months ago (2013-03-18 03:47:03 UTC) #1
Andrew T Wilson (Slow)
lgtm
7 years, 9 months ago (2013-03-19 19:19:28 UTC) #2
jackhou1
Hi jhawkins, Could you please review for owners? Thanks.
7 years, 9 months ago (2013-03-20 00:44:56 UTC) #3
jackhou1
Ping.
7 years, 8 months ago (2013-04-08 03:26:03 UTC) #4
Andrew T Wilson (Slow)
Dan, do you mind giving this your owners rubberstamp? I'd like to get this cleanup ...
7 years, 8 months ago (2013-04-16 13:18:30 UTC) #5
Dan Beam
lgtm
7 years, 8 months ago (2013-04-16 23:43:49 UTC) #6
Andrew T Wilson (Slow)
On 2013/04/16 23:43:49, Dan Beam wrote: > lgtm Thanks, Dan. Jackhou, can you rebase and ...
7 years, 8 months ago (2013-04-17 08:20:37 UTC) #7
jackhou1
On 2013/04/17 08:20:37, Andrew T Wilson wrote: > On 2013/04/16 23:43:49, Dan Beam wrote: > ...
7 years, 8 months ago (2013-04-18 00:11:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/12601017/14001
7 years, 8 months ago (2013-04-18 06:52:04 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 08:20:32 UTC) #10
Message was sent while issue was closed.
Change committed as 194845

Powered by Google App Engine
This is Rietveld 408576698