Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 12601006: Removing base::DictionaryValue::key_iterator. (Closed)

Created:
7 years, 9 months ago by pneubeck (no reviews)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, kkania, sail+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Removing base::DictionaryValue::key_iterator which was displaced by DictionaryValue::Iterator. BUG=162611 TBR=kkania@chromium.org (for webdriver), kalman@chromium.org (for extensions) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187203

Patch Set 1 #

Patch Set 2 : Initial patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -123 lines) Patch
M base/values.h View 1 chunk +0 lines, -27 lines 0 comments Download
M base/values.cc View 3 chunks +19 lines, -34 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/net/transport_security_persister.cc View 1 5 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/policy/component_cloud_policy_store.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/test/webdriver/webdriver_capabilities_parser.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/test/webdriver/webdriver_util.cc View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pneubeck (no reviews)
@Bartosz, PTAL at chrome/browser/policy/component_cloud_policy_store.cc thanks.
7 years, 9 months ago (2013-03-08 09:18:52 UTC) #1
bartfab (slow)
lgtm
7 years, 9 months ago (2013-03-08 09:30:52 UTC) #2
pneubeck (no reviews)
Hi William, this is the final CL that removes key_iterator! Yuhuu :-) Please review this ...
7 years, 9 months ago (2013-03-08 09:32:44 UTC) #3
pneubeck (no reviews)
Hi William, this is the final CL that removes key_iterator! Yuhuu :-) Please review this ...
7 years, 9 months ago (2013-03-08 09:32:44 UTC) #4
willchan no longer on Chromium
lgtm
7 years, 9 months ago (2013-03-08 16:46:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/12601006/2001
7 years, 9 months ago (2013-03-10 08:26:47 UTC) #6
commit-bot: I haz the power
Presubmit check for 12601006-2001 failed and returned exit status 1. INFO:root:Found 10 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-10 08:26:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/12601006/2001
7 years, 9 months ago (2013-03-10 08:32:01 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-10 11:32:51 UTC) #9
Message was sent while issue was closed.
Change committed as 187203

Powered by Google App Engine
This is Rietveld 408576698