Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8035)

Unified Diff: chrome/test/webdriver/webdriver_capabilities_parser.cc

Issue 12601006: Removing base::DictionaryValue::key_iterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial patch. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_info_cache.cc ('k') | chrome/test/webdriver/webdriver_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/webdriver_capabilities_parser.cc
diff --git a/chrome/test/webdriver/webdriver_capabilities_parser.cc b/chrome/test/webdriver/webdriver_capabilities_parser.cc
index 606c598b5b5ac0a9dacbf9b03b66b71be3fa4775..ccca4d004c72031524528f36ef0c40d4e2144f1a 100644
--- a/chrome/test/webdriver/webdriver_capabilities_parser.cc
+++ b/chrome/test/webdriver/webdriver_capabilities_parser.cc
@@ -296,10 +296,11 @@ Error* CapabilitiesParser::ParseProxy(const base::Value* option) {
proxy_options.insert("sslProxy");
proxy_options.insert("class"); // Created by BeanToJSONConverter.
- DictionaryValue::key_iterator key_iter = options->begin_keys();
- for (; key_iter != options->end_keys(); ++key_iter) {
- if (proxy_options.find(*key_iter) == proxy_options.end()) {
- logger_.Log(kInfoLogLevel, "Unrecognized proxy capability: " + *key_iter);
+ for (DictionaryValue::Iterator iter(*options); !iter.IsAtEnd();
+ iter.Advance()) {
+ if (proxy_options.find(iter.key()) == proxy_options.end()) {
+ logger_.Log(kInfoLogLevel,
+ "Unrecognized proxy capability: " + iter.key());
}
}
« no previous file with comments | « chrome/browser/profiles/profile_info_cache.cc ('k') | chrome/test/webdriver/webdriver_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698