Provide metadata to validator to allow faster caching.

Provide metadata to validator to allow faster caching.

This change allows hashless validation caching for the IRT.

BUG= http://code.google.com/p/chromium/issues/detail?id=224434

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=11112

[bsy, 2013-03-28 00:11:49]

comments so far.

https://codereview.chromium.org/12600034/diff/55004/src/trusted/service_runti...
File src/trusted/service_runtime/elf_util.c (right):

https://codereview.chromium.org/12600034/diff/55004/src/trusted/service_runti...
src/trusted/service_runtime/elf_util.c:684: if (metadata) {
NULL != metadata consistent w/ style here write.
yodaspeak you need not use.
but compare ints w/ 0, use ! or naked var name for bools, and explicit
comparisons w/ NULL for pointers, even though any would work, the style guide
says.

https://codereview.chromium.org/12600034/diff/55004/src/trusted/service_runti...
File src/trusted/service_runtime/sel_main_chrome.c (right):

https://codereview.chromium.org/12600034/diff/55004/src/trusted/service_runti...
src/trusted/service_runtime/sel_main_chrome.c:119:
ValidationMetadataForFD(file_desc, kFakeIrtName, sizeof(kFakeIrtName),
just to be clearer, maybe a comment that the kFakeIrtName has an ASCII NUL on
both ends?

[bsy, 2013-03-31 22:04:47]

lgtm.  thx!

[commit-bot: I haz the power, 2013-04-01 21:06:48]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/ncbray@chromium.org/12600034/100001

[commit-bot: I haz the power, 2013-04-01 21:07:13]

Presubmit check for 12600034-100001 failed and returned exit status 1.

INFO:root:Found 28 file(s).
Running presubmit commit checks ...
Running /b/commit-queue/workdir/nacl/PRESUBMIT.py
Error processing
/b/commit-queue/workdir/nacl/site_scons/site_tools/library_deps.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    src/trusted/validator_arm/ncvalidate.cc

Presubmit checks took 3.0s to calculate.

[Nick Bray (chromium), 2013-04-01 21:09:52]

Adding OWNERS for validator_arm - need rubber stamp, change only affects the
validator interface, not the actual validator.

[JF, 2013-04-01 21:16:53]

ARM change lgtm, I didn't look at the rest.

[commit-bot: I haz the power, 2013-04-01 21:19:06]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/ncbray@chromium.org/12600034/100001

[commit-bot: I haz the power, 2013-04-01 23:34:37]

Change committed as 11112

[Sam Clegg, 2013-04-03 16:27:06]

https://chromiumcodereview.appspot.com/12600034/diff/100001/src/trusted/valid...
File src/trusted/validator/validator.gyp (right):

https://chromiumcodereview.appspot.com/12600034/diff/100001/src/trusted/valid...
src/trusted/validator/validator.gyp:68: },
I think this change breaks the chrome win64 build:

http://build.chromium.org/p/tryserver.chromium/builders/win_x64_rel/builds/6421

I was trying to roll deps and ran into this issue.

It seems that the platform64 target only exists on ia32.  I think this whole
block (all the 64 targets) should now be
conditional on ia32.

Is that the correct fix here noel?