Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: src/trusted/validator/x86/64/ncvalidate.c

Issue 12600034: Provide metadata to validator to allow faster caching. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: First fixes Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/x86/64/ncvalidate.c
diff --git a/src/trusted/validator/x86/64/ncvalidate.c b/src/trusted/validator/x86/64/ncvalidate.c
index 9a41e4c2b73f4ee3b4f0f60ac64f662fadfee9dd..5d8f3d6d0f29fe81f842c01ef43762d42e55ca8f 100644
--- a/src/trusted/validator/x86/64/ncvalidate.c
+++ b/src/trusted/validator/x86/64/ncvalidate.c
@@ -45,6 +45,7 @@ static NaClValidationStatus ApplyValidator_x86_64(
int stubout_mode,
int readonly_text,
const NaClCPUFeatures *f,
+ const struct NaClValidationMetadata *metadata,
struct NaClValidationCache *cache) {
/* TODO(jfb) Use a safe cast here. */
const NaClCPUFeaturesX86 *cpu_features = (NaClCPUFeaturesX86 *) f;
@@ -70,7 +71,7 @@ static NaClValidationStatus ApplyValidator_x86_64(
const char validator_id[] = "x86-64";
cache->AddData(query, (uint8_t *) validator_id, sizeof(validator_id));
cache->AddData(query, (uint8_t *) cpu_features, sizeof(*cpu_features));
- cache->AddData(query, data, size);
+ AddCodeIdentity(data, size, metadata, cache, query);
if (cache->QueryKnownToValidate(query)) {
cache->DestroyQuery(query);
return NaClValidationSucceeded;

Powered by Google App Engine
This is Rietveld 408576698