Support type variables as expressions.

Support type variables as expressions.

BUG=dartbug.com/6248

Committed: https://code.google.com/p/dart/source/detail?r=19850

[ngeoffray, 2013-03-11 10:24:06]

https://chromiumcodereview.appspot.com/12598003/diff/1/sdk/lib/_internal/comp...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/12598003/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/compiler.dart:144: void
registerTypeVariable() {}
TypeVariableUsedAsExpression ?

https://chromiumcodereview.appspot.com/12598003/diff/1/sdk/lib/_internal/comp...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://chromiumcodereview.appspot.com/12598003/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2186:
ClassElement cls = target.getEnclosingClass();
assert that cls is also the enclosing class of the currently analyzed method?

https://chromiumcodereview.appspot.com/12598003/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2187:
compiler.world.classesUsingVariableExpression.add(cls);
classesUsingTypeVariableExpression.

https://chromiumcodereview.appspot.com/12598003/diff/1/sdk/lib/_internal/comp...
File sdk/lib/_internal/compiler/implementation/world.dart (right):

https://chromiumcodereview.appspot.com/12598003/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/world.dart:17: final Set<ClassElement>
classesUsingVariableExpression;
Isn't that just an rtiDependency? So could  you just call registerRtiDependency
instead of having another set?

https://chromiumcodereview.appspot.com/12598003/diff/1/tests/language/languag...
File tests/language/language_dart2js.status (right):

https://chromiumcodereview.appspot.com/12598003/diff/1/tests/language/languag...
tests/language/language_dart2js.status:6: illegal_invocation_test/05: Fail # For
a typevariable T, T() is a legal expression now.
Fail, OK? Or update the test?

[ahe, 2013-03-11 13:11:24]

DBC

https://chromiumcodereview.appspot.com/12598003/diff/1/sdk/lib/_internal/comp...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://chromiumcodereview.appspot.com/12598003/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2187:
compiler.world.classesUsingVariableExpression.add(cls);
Could you please make an abstraction rather than adding elements to a set.

By abstraction, I mean add a method to compiler.world, such as:

compiler.world.registerClassUsingTypeVariableAsExpression(cls)

[karlklose, 2013-03-12 09:05:02]

https://codereview.chromium.org/12598003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/12598003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/compiler.dart:144: void
registerTypeVariable() {}
Renamed to registerTypeVariableExpression.

https://codereview.chromium.org/12598003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12598003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2186:
ClassElement cls = target.getEnclosingClass();
On 2013/03/11 10:24:06, ngeoffray wrote:
> assert that cls is also the enclosing class of the currently analyzed method?

Done.

https://codereview.chromium.org/12598003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2187:
compiler.world.classesUsingVariableExpression.add(cls);
Done, good point.

https://codereview.chromium.org/12598003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2187:
compiler.world.classesUsingVariableExpression.add(cls);
On 2013/03/11 10:24:06, ngeoffray wrote:
> classesUsingTypeVariableExpression.

Done.

https://codereview.chromium.org/12598003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/world.dart (right):

https://codereview.chromium.org/12598003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/world.dart:17: final Set<ClassElement>
classesUsingVariableExpression;
No, this class and its subclasses need RTI because the method creates a Dart
value from them. The dependency would be between the method being called and the
class, but we do not track that.

https://codereview.chromium.org/12598003/diff/1/tests/language/language_dart2...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/12598003/diff/1/tests/language/language_dart2...
tests/language/language_dart2js.status:6: illegal_invocation_test/05: Fail # For
a typevariable T, T() is a legal expression now.
Changed to 'Fail, OK'.

[ngeoffray, 2013-03-12 09:18:06]

LGTM

https://codereview.chromium.org/12598003/diff/9009/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12598003/diff/9009/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2204:
compiler.world.registerClassUsingVariableExpression(cls);
As discussed, it'd be nice to not have to do this, and have all rti things being
handled in the backend.

https://codereview.chromium.org/12598003/diff/9009/tests/language/language_da...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/12598003/diff/9009/tests/language/language_da...
tests/language/language_dart2js.status:6: illegal_invocation_test/05: Fail, OK #
For a typevariable T, T() is a legal expression now.
typevariable -> type variable

And as discussed, it might make sense just to remove the test, or make it a
different negative test.

[karlklose, 2013-03-12 09:35:22]

Thanks, Nicolas!

https://codereview.chromium.org/12598003/diff/9009/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12598003/diff/9009/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2204:
compiler.world.registerClassUsingVariableExpression(cls);
I'll move all RTI infrastructure from World to RuntimeTypeInformation in a
follow up CL.

https://codereview.chromium.org/12598003/diff/9009/tests/language/language_da...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/12598003/diff/9009/tests/language/language_da...
tests/language/language_dart2js.status:6: illegal_invocation_test/05: Fail, OK #
For a typevariable T, T() is a legal expression now.
I changed the test.

[karlklose, 2013-03-12 11:21:34]

Committed patchset #3 manually as r19850 (presubmit successful).