Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12581004: Move InsertSyncPoint to GLES2Interface (Closed)

Created:
7 years, 9 months ago by piman
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Move InsertSyncPoint to GLES2Interface This is needed to allow Pepper to use mailboxes rather than parenting to integrate with the compositor. BUG=164095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186869

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -9 lines) Patch
M content/common/gpu/client/command_buffer_proxy_impl.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/command_buffer.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/command_buffer_mock.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 4 chunks +19 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
7 years, 9 months ago (2013-03-07 05:57:16 UTC) #1
greggman
lgtm
7 years, 9 months ago (2013-03-07 17:18:07 UTC) #2
piman
+Justin for IPC (Exposes a synchronization token to Pepper) +Trung for ppapi/
7 years, 9 months ago (2013-03-07 17:25:32 UTC) #3
jschuh
rubberstamp lgtm. no security change.
7 years, 9 months ago (2013-03-07 20:29:59 UTC) #4
viettrungluu
lgtm
7 years, 9 months ago (2013-03-08 00:46:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/12581004/4001
7 years, 9 months ago (2013-03-08 00:51:20 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-08 03:08:09 UTC) #7
Message was sent while issue was closed. 
Change committed as 186869

Powered by Google App Engine
This is Rietveld 408576698