Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: ui/base/ime/input_method_auralinux.h

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method.h ('k') | ui/base/ime/input_method_auralinux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_auralinux.h
diff --git a/ui/base/ime/input_method_auralinux.h b/ui/base/ime/input_method_auralinux.h
index fec733b531ff488d2269df987549d0c7286a8700..05a80d7798bc445e0a37eda7286a723e055e5b9f 100644
--- a/ui/base/ime/input_method_auralinux.h
+++ b/ui/base/ime/input_method_auralinux.h
@@ -27,7 +27,7 @@ class UI_BASE_IME_EXPORT InputMethodAuraLinux
// Overriden from InputMethod.
bool OnUntranslatedIMEMessage(const base::NativeEvent& event,
NativeEventResult* result) override;
- bool DispatchKeyEvent(const ui::KeyEvent& event) override;
+ void DispatchKeyEvent(ui::KeyEvent* event) override;
void OnTextInputTypeChanged(const TextInputClient* client) override;
void OnCaretBoundsChanged(const TextInputClient* client) override;
void CancelComposition(const TextInputClient* client) override;
@@ -53,7 +53,7 @@ class UI_BASE_IME_EXPORT InputMethodAuraLinux
private:
bool HasInputMethodResult();
bool NeedInsertChar() const;
- bool SendFakeProcessKeyEvent(int flags) const;
+ ui::EventDispatchDetails SendFakeProcessKeyEvent(ui::KeyEvent* event) const;
void ConfirmCompositionText();
void UpdateContextFocusState();
void ResetContext();
@@ -80,12 +80,6 @@ class UI_BASE_IME_EXPORT InputMethodAuraLinux
// event will be discarded.
bool suppress_next_result_;
- // The pointer to a boolean value which indicates whether this InputMethod
- // instance is destroyed. This is used in DispatchKeyEvent to detect whether
- // DispatchKeyEventPostIME will cause destruction of this InputMethod
- // instance. See crbug.com/513917.
- bool* destroyed_ptr_;
-
DISALLOW_COPY_AND_ASSIGN(InputMethodAuraLinux);
};
« no previous file with comments | « ui/base/ime/input_method.h ('k') | ui/base/ime/input_method_auralinux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698