ui/base/ime/input_method.h - Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method.h

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/ime/input_method.h

diff --git a/ui/base/ime/input_method.h b/ui/base/ime/input_method.h

index dc0a43eb1716978c52bee30a2412a9e627ae9bf2..21b02354b2c35b43edf63af9e026256fcd7fcb67 100644

--- a/ui/base/ime/input_method.h

+++ b/ui/base/ime/input_method.h

@@ -91,8 +91,7 @@ class InputMethod {

// dispatched back to the caller via

// ui::InputMethodDelegate::DispatchKeyEventPostIME(), once it's processed by

// the input method. It should only be called by a message dispatcher.

- // Returns true if the event was processed.

- virtual bool DispatchKeyEvent(const ui::KeyEvent& event) = 0;

+ virtual void DispatchKeyEvent(ui::KeyEvent* event) = 0;

// Called by the focused client whenever its text input type is changed.

// Before calling this method, the focused client must confirm or clear

« no previous file with comments | « ui/base/ime/dummy_input_method.cc ('k') | ui/base/ime/input_method_auralinux.h » ('j') | no next file with comments »