Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1256183004: Fixed crashed when activating the context menu for toolbar buttons using Voiceover (Closed)

Created:
5 years, 4 months ago by nektarios
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed crashed when activating the context menu for toolbar buttons that are found in the browser's UI, e.g. Reload button. TESTED=Manual testing BUG=515909 R=dmazzoni@chromium.org, avi@chromium.org Committed: https://crrev.com/2cea93b6c01a158d390f8a93a28656c8c6ee0d2e Cr-Commit-Position: refs/heads/master@{#341800}

Patch Set 1 #

Patch Set 2 : Reset cell properties to defaults if a menu is not attached or has been removed. #

Patch Set 3 : Rebased on master. #

Patch Set 4 : Fixed compiler issue. #

Patch Set 5 : Removed DCHECK that made having both a long click menu and a right click menu active at the same ti… #

Patch Set 6 : Fixed clicking on menu buttons. #

Patch Set 7 : Separated mouse and accessibility actions. #

Patch Set 8 : Removed outdated DCHECK. #

Total comments: 1

Patch Set 9 : Fixed indentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -19 lines) Patch
M chrome/browser/ui/cocoa/clickhold_button_cell.h View 1 2 3 4 5 6 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/clickhold_button_cell.mm View 1 2 3 4 5 6 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/clickhold_button_cell_unittest.mm View 1 2 3 4 5 6 7 8 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/menu_button.mm View 1 2 3 4 5 6 7 3 chunks +37 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/menu_button_unittest.mm View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
nektarios
5 years, 4 months ago (2015-07-30 21:18:05 UTC) #1
dmazzoni
Looks fine, but avi or some other owner needs to review, not me.
5 years, 4 months ago (2015-07-31 22:26:03 UTC) #2
nektarios
+Avi
5 years, 4 months ago (2015-08-01 02:20:00 UTC) #4
Avi (use Gerrit)
LGTM with small formatting nit fixed. https://codereview.chromium.org/1256183004/diff/140001/chrome/browser/ui/cocoa/clickhold_button_cell_unittest.mm File chrome/browser/ui/cocoa/clickhold_button_cell_unittest.mm (right): https://codereview.chromium.org/1256183004/diff/140001/chrome/browser/ui/cocoa/clickhold_button_cell_unittest.mm#newcode125 chrome/browser/ui/cocoa/clickhold_button_cell_unittest.mm:125: [cell setEnableRightClick:YES]; indent ...
5 years, 4 months ago (2015-08-01 03:58:51 UTC) #5
nektarios
Indentation fixed.
5 years, 4 months ago (2015-08-04 20:24:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256183004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256183004/160001
5 years, 4 months ago (2015-08-04 20:25:31 UTC) #9
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 4 months ago (2015-08-04 21:29:16 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 21:31:25 UTC) #11
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/2cea93b6c01a158d390f8a93a28656c8c6ee0d2e
Cr-Commit-Position: refs/heads/master@{#341800}

Powered by Google App Engine
This is Rietveld 408576698