Add the allocator intrinsics for dart:typeddata implementation.

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 449 matching lines @@
 
 // Gets the length of a ByteArray.
 bool Intrinsifier::ByteArrayBase_getLength(Assembler* assembler) {
   __ movl(EAX, Address(ESP, + 1 * kWordSize));
   __ movl(EAX, FieldAddress(EAX, ByteArray::length_offset()));
   __ ret();
   return true;
 }
 
 
-#define TYPED_ARRAY_ALLOCATION(type_name, scale_factor)                        \
+#define TYPED_ARRAY_ALLOCATION(type_name, cid, max_len, scale_factor)          \
   Label fall_through;                                                          \
   const intptr_t kArrayLengthStackOffset = 1 * kWordSize;                      \
   __ movl(EDI, Address(ESP, kArrayLengthStackOffset));  /* Array length. */    \
   /* Check that length is a positive Smi. */                                   \
   /* EDI: requested array length argument. */                                  \
   __ testl(EDI, Immediate(kSmiTagSize));                                       \
   __ j(NOT_ZERO, &fall_through);                                               \
   __ cmpl(EDI, Immediate(0));                                                  \
   __ j(LESS, &fall_through);                                                   \
   __ SmiUntag(EDI);                                                            \
   /* Check for maximum allowed length. */                                      \
   /* EDI: untagged array length. */                                            \
-  __ cmpl(EDI, Immediate(type_name::kMaxElements));                            \
+  __ cmpl(EDI, Immediate(max_len));                                            \
   __ j(GREATER, &fall_through);                                                \
   const intptr_t fixed_size = sizeof(Raw##type_name) + kObjectAlignment - 1;   \
   __ leal(EDI, Address(EDI, scale_factor, fixed_size));                        \
   __ andl(EDI, Immediate(-kObjectAlignment));                                  \
   Heap* heap = Isolate::Current()->heap();                                     \
                                                                                \
   __ movl(EAX, Address::Absolute(heap->TopAddress()));                         \
   __ movl(EBX, EAX);                                                           \
                                                                                \
   /* EDI: allocation size. */                                                  \
@@ skipping 21 matching lines @@
     __ cmpl(EDI, Immediate(RawObject::SizeTag::kMaxSizeTag));                  \
     __ j(ABOVE, &size_tag_overflow, Assembler::kNearJump);                     \
     __ shll(EDI, Immediate(RawObject::kSizeTagBit - kObjectAlignmentLog2));    \
     __ jmp(&done, Assembler::kNearJump);                                       \
                                                                                \
     __ Bind(&size_tag_overflow);                                               \
     __ movl(EDI, Immediate(0));                                                \
     __ Bind(&done);                                                            \
                                                                                \
     /* Get the class index and insert it into the tags. */                     \
-    __ orl(EDI, Immediate(RawObject::ClassIdTag::encode(k##type_name##Cid)));  \
+    __ orl(EDI, Immediate(RawObject::ClassIdTag::encode(cid)));                \
     __ movl(FieldAddress(EAX, type_name::tags_offset()), EDI);  /* Tags. */    \
   }                                                                            \
   /* Set the length field. */                                                  \
   /* EAX: new object start as a tagged pointer. */                             \
   /* EBX: new object end address. */                                           \
   __ movl(EDI, Address(ESP, kArrayLengthStackOffset));  /* Array length. */    \
   __ StoreIntoObjectNoBarrier(EAX,                                             \
                               FieldAddress(EAX, type_name::length_offset()),   \
                               EDI);                                            \
   /* Initialize all array elements to 0. */                                    \
@@ skipping 10 matching lines @@
   __ j(ABOVE_EQUAL, &done, Assembler::kNearJump);                              \
   __ movl(Address(EDI, 0), ECX);                                               \
   __ addl(EDI, Immediate(kWordSize));                                          \
   __ jmp(&init_loop, Assembler::kNearJump);                                    \
   __ Bind(&done);                                                              \
                                                                                \
   __ ret();                                                                    \
   __ Bind(&fall_through);                                                      \
 
 
-bool Intrinsifier::Int8Array_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Int8Array, TIMES_1);
-  return false;
+#define SCALARLIST_ALLOCATOR(clazz, scale)                                     \
+bool Intrinsifier::clazz##_new(Assembler* assembler) {                         \
+  TYPED_ARRAY_ALLOCATION(clazz, k##clazz##Cid, clazz::kMaxElements, scale);    \
+  return false;                                                                \
+}                                                                              \
+bool Intrinsifier::clazz##_factory(Assembler* assembler) {                     \
+  TYPED_ARRAY_ALLOCATION(clazz, k##clazz##Cid, clazz::kMaxElements, scale);    \
+  return false;                                                                \
 }
 
 
-bool Intrinsifier::Int8Array_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Int8Array, TIMES_1);
-  return false;
-}
-
-
-bool Intrinsifier::Uint8Array_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Uint8Array, TIMES_1);
-  return false;
-}
-
-
-bool Intrinsifier::Uint8Array_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Uint8Array, TIMES_1);
-  return false;
-}
-
-
-bool Intrinsifier::Uint8ClampedArray_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Uint8ClampedArray, TIMES_1);
-  return false;
-}
-
-
-bool Intrinsifier::Uint8ClampedArray_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Uint8ClampedArray, TIMES_1);
-  return false;
-}
-
-
-bool Intrinsifier::Int16Array_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Int16Array, TIMES_2);
-  return false;
-}
-
-
-bool Intrinsifier::Int16Array_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Int16Array, TIMES_2);
-  return false;
-}
-
-
-bool Intrinsifier::Uint16Array_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Uint16Array, TIMES_2);
-  return false;
-}
-
-
-bool Intrinsifier::Uint16Array_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Uint16Array, TIMES_2);
-  return false;
-}
-
-
-bool Intrinsifier::Int32Array_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Int32Array, TIMES_4);
-  return false;
-}
-
-
-bool Intrinsifier::Int32Array_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Int32Array, TIMES_4);
-  return false;
-}
-
-
-bool Intrinsifier::Uint32Array_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Uint32Array, TIMES_4);
-  return false;
-}
-
-
-bool Intrinsifier::Uint32Array_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Uint32Array, TIMES_4);
-  return false;
-}
+SCALARLIST_ALLOCATOR(Int8Array, TIMES_1)
+SCALARLIST_ALLOCATOR(Uint8Array, TIMES_1)
+SCALARLIST_ALLOCATOR(Uint8ClampedArray, TIMES_1)
+SCALARLIST_ALLOCATOR(Int16Array, TIMES_2)
+SCALARLIST_ALLOCATOR(Uint16Array, TIMES_2)
+SCALARLIST_ALLOCATOR(Int32Array, TIMES_4)
+SCALARLIST_ALLOCATOR(Uint32Array, TIMES_4)
+SCALARLIST_ALLOCATOR(Int64Array, TIMES_8)
+SCALARLIST_ALLOCATOR(Uint64Array, TIMES_8)
+SCALARLIST_ALLOCATOR(Float32Array, TIMES_4)
+SCALARLIST_ALLOCATOR(Float64Array, TIMES_8)
 
 
 bool Intrinsifier::Int64Array_getIndexed(Assembler* assembler) {
   return false;
 }
 
 
-bool Intrinsifier::Int64Array_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Int64Array, TIMES_8);
-  return false;
-}
-
-
-bool Intrinsifier::Int64Array_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Int64Array, TIMES_8);
-  return false;
-}
-
-
 bool Intrinsifier::Uint64Array_getIndexed(Assembler* assembler) {
   return false;
 }
 
 
-bool Intrinsifier::Uint64Array_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Uint64Array, TIMES_8);
-  return false;
+// Gets the length of a TypedData.
+bool Intrinsifier::TypedData_getLength(Assembler* assembler) {
+  __ movl(EAX, Address(ESP, + 1 * kWordSize));
+  __ movl(EAX, FieldAddress(EAX, TypedData::length_offset()));
+  __ ret();
+  return true;
 }
 
 
-bool Intrinsifier::Uint64Array_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Uint64Array, TIMES_8);
-  return false;
-}
+static ScaleFactor GetScaleFactor(intptr_t size) {
+  switch (size) {
+    case 1: return TIMES_1;
+    case 2: return TIMES_2;
+    case 4: return TIMES_4;
+    case 8: return TIMES_8;
+  }
+  UNREACHABLE();
+  return static_cast<ScaleFactor>(0);
+};

[srdjan, 2013/03/08 17:40:24]

Maybe we could factor this out. There are 3 identical versions of the code above
(flow_graph_compiler_xxx.cc).

[siva, 2013/03/09 00:02:48]

Good idea, In an new CL I will factor this into Utils.

On 2013/03/08 17:40:24, srdjan wrote:

 
 
-bool Intrinsifier::Float32Array_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Float32Array, TIMES_4);
-  return false;
+#define TYPEDDATA_ALLOCATOR(clazz)                                             \
+bool Intrinsifier::TypedData_##clazz##_new(Assembler* assembler) {             \
+  intptr_t size = TypedData::ElementSizeInBytes(kTypedData##clazz##Cid);       \
+  intptr_t max_len = kSmiMax / size;                                           \

[srdjan, 2013/03/08 17:40:24]

max_len may be needed by other parts of code. Please factor it out.

[siva, 2013/03/09 00:02:48]

I have added TypedData::MaxElements which computes the max elements and used
this everywhere.

On 2013/03/08 17:40:24, srdjan wrote:

+  ScaleFactor scale = GetScaleFactor(size);                                    \
+  TYPED_ARRAY_ALLOCATION(TypedData, kTypedData##clazz##Cid, max_len, scale);   \
+  return false;                                                                \
+}                                                                              \
+bool Intrinsifier::TypedData_##clazz##_factory(Assembler* assembler) {         \
+  intptr_t size = TypedData::ElementSizeInBytes(kTypedData##clazz##Cid);       \
+  intptr_t max_len = kSmiMax / size;                                           \
+  ScaleFactor scale = GetScaleFactor(size);                                    \
+  TYPED_ARRAY_ALLOCATION(TypedData, kTypedData##clazz##Cid, max_len, scale);   \
+  return false;                                                                \
 }
-
-
-bool Intrinsifier::Float32Array_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Float32Array, TIMES_4);
-  return false;
-}
-
-
-bool Intrinsifier::Float64Array_new(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Float64Array, TIMES_8);
-  return false;
-}
-
-
-bool Intrinsifier::Float64Array_factory(Assembler* assembler) {
-  TYPED_ARRAY_ALLOCATION(Float64Array, TIMES_8);
-  return false;
-}
+CLASS_LIST_TYPED_DATA(TYPEDDATA_ALLOCATOR)
+#undef TYPEDDATA_ALLOCATOR
 
 
 // Tests if two top most arguments are smis, jumps to label not_smi if not.
 // Topmost argument is in EAX.
 static void TestBothArgumentsSmis(Assembler* assembler, Label* not_smi) {
   __ movl(EAX, Address(ESP, + 1 * kWordSize));
   __ movl(EBX, Address(ESP, + 2 * kWordSize));
   __ orl(EBX, EAX);
   __ testl(EBX, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, not_smi, Assembler::kNearJump);
@@ skipping 891 matching lines @@
   __ SmiTag(EAX);
   __ movl(FieldAddress(EBX, String::hash_offset()), EAX);
   __ ret();
   return true;
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32