Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 12547018: Add the allocator intrinsics for dart:typeddata implementation. (Closed)

Created:
7 years, 9 months ago by siva
Modified:
7 years, 9 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add the allocator intrinsics for dart:typeddata implementation. Committed: https://code.google.com/p/dart/source/detail?r=19752

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -246 lines) Patch
M runtime/lib/typeddata.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 2 4 chunks +54 lines, -122 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 2 6 chunks +57 lines, -122 lines 0 comments Download
M runtime/vm/object.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
siva
7 years, 9 months ago (2013-03-08 02:28:37 UTC) #1
Ivan Posva
LGTM -ip
7 years, 9 months ago (2013-03-08 09:38:51 UTC) #2
srdjan
LGTM https://chromiumcodereview.appspot.com/12547018/diff/7001/runtime/vm/intrinsifier_ia32.cc File runtime/vm/intrinsifier_ia32.cc (right): https://chromiumcodereview.appspot.com/12547018/diff/7001/runtime/vm/intrinsifier_ia32.cc#newcode608 runtime/vm/intrinsifier_ia32.cc:608: }; Maybe we could factor this out. There ...
7 years, 9 months ago (2013-03-08 17:40:24 UTC) #3
siva
https://chromiumcodereview.appspot.com/12547018/diff/7001/runtime/vm/intrinsifier_ia32.cc File runtime/vm/intrinsifier_ia32.cc (right): https://chromiumcodereview.appspot.com/12547018/diff/7001/runtime/vm/intrinsifier_ia32.cc#newcode608 runtime/vm/intrinsifier_ia32.cc:608: }; Good idea, In an new CL I will ...
7 years, 9 months ago (2013-03-09 00:02:48 UTC) #4
siva
7 years, 9 months ago (2013-03-09 00:06:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r19752 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698