Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 12544027: Skip subprocess2_test suite on upload. (Closed)

Created:
7 years, 9 months ago by Isaac (away)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Skip subprocess2_test suite on upload. This suite is very slow (26s), while the rest of the test suites are fast.. Since subprocess2 is a relatively static module, blacklist the suite for upload. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=188657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Isaac (away)
7 years, 9 months ago (2013-03-17 04:21:40 UTC) #1
Marc-Antoine Ruel (Google)
lgtm
7 years, 9 months ago (2013-03-17 12:46:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/12544027/1
7 years, 9 months ago (2013-03-17 23:16:00 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-17 23:18:39 UTC) #4
Message was sent while issue was closed.
Change committed as 188657

Powered by Google App Engine
This is Rietveld 408576698