Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: PRESUBMIT.py

Issue 12544027: Skip subprocess2_test suite on upload. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for depot tools. 5 """Top-level presubmit script for depot tools.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into depot_tools. 8 details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 server.stop_server() 89 server.stop_server()
90 return results 90 return results
91 91
92 92
93 def CheckChangeOnUpload(input_api, output_api): 93 def CheckChangeOnUpload(input_api, output_api):
94 # Do not run integration tests on upload since they are way too slow. 94 # Do not run integration tests on upload since they are way too slow.
95 tests_to_black_list = [ 95 tests_to_black_list = [
96 r'^checkout_test\.py$', 96 r'^checkout_test\.py$',
97 r'^gclient_smoketest\.py$', 97 r'^gclient_smoketest\.py$',
98 r'^scm_unittest\.py$', 98 r'^scm_unittest\.py$',
99 r'^subprocess2_test\.py$',
99 ] 100 ]
100 return CommonChecks(input_api, output_api, tests_to_black_list) 101 return CommonChecks(input_api, output_api, tests_to_black_list)
101 102
102 103
103 def CheckChangeOnCommit(input_api, output_api): 104 def CheckChangeOnCommit(input_api, output_api):
104 output = [] 105 output = []
105 output.extend(CommonChecks(input_api, output_api, [])) 106 output.extend(CommonChecks(input_api, output_api, []))
106 output.extend(input_api.canned_checks.CheckDoNotSubmit( 107 output.extend(input_api.canned_checks.CheckDoNotSubmit(
107 input_api, 108 input_api,
108 output_api)) 109 output_api))
109 output.extend(RunGitClTests(input_api, output_api)) 110 output.extend(RunGitClTests(input_api, output_api))
110 return output 111 return output
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698