Port SIMD types from dart:scalarlist to dart:typeddata.

Port SIMD types from dart:scalarlist to dart:typeddata.

Committed: https://code.google.com/p/dart/source/detail?r=20522

[Cutch, 2013-03-09 01:34:19]

Hi Siva,

This CL is near complete. Feel free to review it.

NOTE: I think there are bugs in typeddata views:

1) They take ByteBuffer but ByteBuffer lacks the necessary methods.
2) Passing in a ByteDataView works, but, the offset is wrong.

John

[siva, 2013-03-12 11:44:22]

Your SIMD changes LGTM.

Regarding your comment about typedata views, yes they take a bytebuffer as input
but we always pass in a typeddata to it and hence it should have all the methods
implemented on it. If you see the constructor of the views it has typedata_ as
TypedData.

https://chromiumcodereview.appspot.com/12534006/diff/1/runtime/lib/typeddata....
File runtime/lib/typeddata.dart (right):

https://chromiumcodereview.appspot.com/12534006/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.dart:1224: // Internal utility methods.
If you sync up to the latest sources there is a new method _createList that you
need to implement. This was need because getRange in TYpedListBase was calling
'_new' which is a static method which would be incorrect, hence the need for an
instance method which creates a new instance.

https://chromiumcodereview.appspot.com/12534006/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.dart:2664: }
Thanks for fixing these.

https://chromiumcodereview.appspot.com/12534006/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/12534006/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:897: RegisterPrivateClass(cls, Symbols::_Uint32x4(), lib);
Why are you adding these classes to the scalarlist library too?

[Cutch, 2013-03-25 21:06:35]

Just running through tests on my machine.

https://codereview.chromium.org/12534006/diff/1/runtime/lib/typeddata.dart
File runtime/lib/typeddata.dart (right):

https://codereview.chromium.org/12534006/diff/1/runtime/lib/typeddata.dart#ne...
runtime/lib/typeddata.dart:1224: // Internal utility methods.
On 2013/03/12 11:44:22, siva wrote:
> If you sync up to the latest sources there is a new method _createList that
you
> need to implement. This was need because getRange in TYpedListBase was calling
> '_new' which is a static method which would be incorrect, hence the need for
an
> instance method which creates a new instance.

Done.

https://codereview.chromium.org/12534006/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/12534006/diff/1/runtime/vm/object.cc#newcode897
runtime/vm/object.cc:897: RegisterPrivateClass(cls, Symbols::_Uint32x4(), lib);
On 2013/03/12 11:44:22, siva wrote:
> Why are you adding these classes to the scalarlist library too?

They were already available to scalarlist. What's the best way to handle
exposing the same class from two libraries?

[siva, 2013-03-25 22:07:04]

lgtm

[Cutch, 2013-03-25 23:09:23]

$ ../tools/test.py -m all -a ia32,x64,simmips,simarm
Test configurations: none_vm_debug_ia32 none_vm_release_ia32 none_vm_debug_x64
none_vm_release_x64 none_vm_debug_simmips none_vm_release_simmips
none_vm_debug_simarm none_vm_release_simarm
[00:00 |  --% | +    0 | -    0]
[39:53 | 100% | +27263 | -    0]

[Cutch, 2013-03-26 16:50:40]

Committed patchset #5 manually as r20522 (presubmit successful).