Chromium Code Reviews Chromium Code Reviews
Issue 12521030:
Extension docs: Include sidenav in 404 pages (Closed)
Base URL: https://src.chromium.org/svn/trunk/src/| Index: chrome/common/extensions/docs/templates/private/404.html |
| =================================================================== |
| --- chrome/common/extensions/docs/templates/private/404.html (revision 190229) |
| +++ chrome/common/extensions/docs/templates/private/404.html (working copy) |
| @@ -2,17 +2,28 @@ |
| <html> |
| <head> |
| {{+partials.header_head}} |
| - <link href="{{static}}/css/index.css" rel="stylesheet" type="text/css"> |
| - <title>404 Not Found - Google Chrome Extensions</title> |
| + <title>404 Not Found - Google Chrome</title> |
| + <base href="/{{branchInfo.current}}/{{platform}}s/"> |
|
not at google - send to devlin
2013/03/26 16:12:19
<base>? Can we avoid?
|
| + <style type="text/css"> |
| + #gc-sidebar.floating { |
| + position: relative; |
|
方觉(Fang Jue)
2013/03/26 13:52:11
This fixes problem with scrolling on 404 pages (wi
not at google - send to devlin
2013/03/26 16:12:19
What do you mean? I patched in this change and it
|
| + } |
| + </style> |
| </head> |
| <body> |
| - {{+partials.header_body title:extensions_title platform:extension}} |
| + {{+partials.header_body}} |
| <div id="gc-container"> |
| + {{+partials.sidenav items:sidenav_items}} |
| <div id="gc-pagecontent"> |
| <h1 class="page_title">404 - Not Found</h1> |
|
not at google - send to devlin
2013/03/26 16:12:19
The 404 here has always irritated me. Let's just m
方觉(Fang Jue)
2013/03/27 00:43:46
Done.
|
| <p>No API or URL found with that name.</p> |
| </div> |
| </div> |
| </body> |
| + <script> |
| + window.bootstrap = { |
| + branchInfo: {{*branchInfo}} |
| + }; |
| + </script> |
| {{+partials.footer}} |
|
not at google - send to devlin
2013/03/26 16:12:19
I think if we make this an article (articles/404.h
方觉(Fang Jue)
2013/03/27 00:43:46
Done.
|
| </html> |
