chrome/common/extensions/docs/templates/private/404.html - Issue 12521030: Extension docs: Include sidenav in 404 pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/404.html

Issue 12521030: Extension docs: Include sidenav in 404 pages (Closed) Base URL: https://src.chromium.org/svn/trunk/src/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/server2/server_instance.py ('K') | « chrome/common/extensions/docs/server2/url_constants.py ('k') | chrome/common/extensions/docs/templates/public/apps/404.html » ('j') | chrome/common/extensions/docs/templates/public/apps/404.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 {{+partials.header_head}}	4 {{+partials.header_head}}

5 <link href="{{static}}/css/index.css" rel="stylesheet" type="text/css">	5 <title>404 Not Found - Google Chrome</title>

6 <title>404 Not Found - Google Chrome Extensions</title>	6 <base href="/{{branchInfo.current}}/{{platform}}s/">
	not at google - send to devlin 2013/03/26 16:12:19 <base>? Can we avoid? <base>? Can we avoid?
	7 <style type="text/css">

	8 #gc-sidebar.floating {

	9 position: relative;
	方觉(Fang Jue) 2013/03/26 13:52:11 This fixes problem with scrolling on 404 pages (wi This fixes problem with scrolling on 404 pages (without it you cannot scroll down to the bottom of the sidenav on a 404 page). not at google - send to devlin 2013/03/26 16:12:19 What do you mean? I patched in this change and it Show quoted text On 2013/03/26 13:52:11, 方觉(Fang Jue) wrote: > This fixes problem with scrolling on 404 pages (without it you cannot scroll > down to the bottom of the sidenav on a 404 page). What do you mean? I patched in this change and it appears to work without it. (Incidentally, if it fixes something here it probably fixes something elsewhere too, so it should be in site.css).
	10 }

	11 </style>

7 </head>	12 </head>

8 <body>	13 <body>

9 {{+partials.header_body title:extensions_title platform:extension}}	14 {{+partials.header_body}}

10 <div id="gc-container">	15 <div id="gc-container">

	16 {{+partials.sidenav items:sidenav_items}}

11 <div id="gc-pagecontent">	17 <div id="gc-pagecontent">

12 <h1 class="page_title">404 - Not Found</h1>	18 <h1 class="page_title">404 - Not Found</h1>
	not at google - send to devlin 2013/03/26 16:12:19 The 404 here has always irritated me. Let's just m The 404 here has always irritated me. Let's just make this "Not found". Also we don't use page_title anymore. 方觉(Fang Jue) 2013/03/27 00:43:46 Done. Show quoted text On 2013/03/26 16:12:19, kalman wrote: > The 404 here has always irritated me. Let's just make this "Not found". > > Also we don't use page_title anymore. Done.
13 <p>No API or URL found with that name.</p>	19 <p>No API or URL found with that name.</p>

14 </div>	20 </div>

15 </div>	21 </div>

16 </body>	22 </body>

	23 <script>

	24 window.bootstrap = {

	25 branchInfo: {{*branchInfo}}

	26 };

	27 </script>

17 {{+partials.footer}}	28 {{+partials.footer}}
	not at google - send to devlin 2013/03/26 16:12:19 I think if we make this an article (articles/404.h I think if we make this an article (articles/404.html) then we can get some of this for free. 方觉(Fang Jue) 2013/03/27 00:43:46 Done. Show quoted text On 2013/03/26 16:12:19, kalman wrote: > I think if we make this an article (articles/404.html) then we can get some of > this for free. Done.
18 </html>	29 </html>

OLD	NEW