Add a command line option to generate source code for a script

Add a command line option to generate source code for a script
(apparently this would be useful for pretty printing the output of
dart2dart)
Committed: https://code.google.com/p/dart/source/detail?r=19996

[Ivan Posva, 2013-03-13 22:30:38]

I am not sure whether this is really the right way to go.
-Ivan

https://codereview.chromium.org/12517005/diff/8/runtime/include/dart_debugger...
File runtime/include/dart_debugger_api.h (right):

https://codereview.chromium.org/12517005/diff/8/runtime/include/dart_debugger...
runtime/include/dart_debugger_api.h:169: DART_EXPORT Dart_Handle
Dart_GenerateScriptSource(Dart_Handle library_url_in,
I am questioning the reason behind adding this API call. Shouldn't there already
be a call which will get you the source for a script?

[siva, 2013-03-14 05:57:34]

https://codereview.chromium.org/12517005/diff/8/runtime/include/dart_debugger...
File runtime/include/dart_debugger_api.h (right):

https://codereview.chromium.org/12517005/diff/8/runtime/include/dart_debugger...
runtime/include/dart_debugger_api.h:169: DART_EXPORT Dart_Handle
Dart_GenerateScriptSource(Dart_Handle library_url_in,
The existing API will return the source available for the script. If there is
already a source provided by the user it will just return that and it won't be
the formatted version that this option is trying to provide. Hence the need to
generate the source for the script.

On 2013/03/13 22:30:38, Ivan Posva wrote:
> I am questioning the reason behind adding this API call. Shouldn't there
already
> be a call which will get you the source for a script?

[bakster, 2013-03-14 08:42:16]

LGTM,
  Lars

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/bin/main.cc#ne...
runtime/bin/main.cc:256: { "--print-script", ProcessPrintScriptOption },
Why are some flags using - and others using _?
How about some consistency?

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/bin/main.cc#ne...
runtime/bin/main.cc:603: "  Generates Dart source code back and prints it after
parsing a Dart script\n"
Consistency: use lowercase "generates"?

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/bin/main.cc#ne...
runtime/bin/main.cc:827: if (has_print_script) {
I would move this chunk of code out in a function.

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/debugger_ap...
File runtime/vm/debugger_api_impl.cc (right):

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/debugger_ap...
runtime/vm/debugger_api_impl.cc:571: DART_EXPORT Dart_Handle
Dart_GenerateScriptSource(Dart_Handle library_url_in,
How about a comment explaining this entry will PrettyPrint source code based on
the tokens.

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/object.cc#n...
runtime/vm/object.cc:5333: return GenerateSource();
Why do you have an else part after return?

if (source.IsNull()) return GenerateSource();
return raw_ptr()->source_;

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/object.h
File runtime/vm/object.h (right):

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/object.h#ne...
runtime/vm/object.h:1933: RawString* GenerateSource() const;
Comment?

[siva, 2013-03-14 09:38:46]

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/bin/main.cc#ne...
runtime/bin/main.cc:256: { "--print-script", ProcessPrintScriptOption },
We are moving to a "-" pattern. Will change the others taht do not conform to
this in a different CL.

On 2013/03/14 08:42:16, bakster wrote:
> Why are some flags using - and others using _?
> How about some consistency?

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/bin/main.cc#ne...
runtime/bin/main.cc:603: "  Generates Dart source code back and prints it after
parsing a Dart script\n"
On 2013/03/14 08:42:16, bakster wrote:
> Consistency: use lowercase "generates"?

Done.

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/bin/main.cc#ne...
runtime/bin/main.cc:827: if (has_print_script) {
On 2013/03/14 08:42:16, bakster wrote:
> I would move this chunk of code out in a function.

Done.

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/debugger_ap...
File runtime/vm/debugger_api_impl.cc (right):

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/debugger_ap...
runtime/vm/debugger_api_impl.cc:571: DART_EXPORT Dart_Handle
Dart_GenerateScriptSource(Dart_Handle library_url_in,
Added the comment in the header file
Added comment in the header file.

On 2013/03/14 08:42:16, bakster wrote:
> How about a comment explaining this entry will PrettyPrint source code based
on
> the tokens.

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/object.cc#n...
runtime/vm/object.cc:5333: return GenerateSource();
On 2013/03/14 08:42:16, bakster wrote:
> Why do you have an else part after return?
> 
> if (source.IsNull()) return GenerateSource();
> return raw_ptr()->source_;

Done.

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/object.h
File runtime/vm/object.h (right):

https://chromiumcodereview.appspot.com/12517005/diff/8/runtime/vm/object.h#ne...
runtime/vm/object.h:1933: RawString* GenerateSource() const;
On 2013/03/14 08:42:16, bakster wrote:
> Comment?

Done.

[siva, 2013-03-14 09:47:50]

Committed patchset #4 manually as r19996 (presubmit successful).