Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12512016: Fix context problem in Android Sync test utilities (Closed)

Created:
7 years, 9 months ago by clamy
Modified:
7 years, 9 months ago
Reviewers:
nyquist
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Fix context problem in Android Sync test utilities BUG=159203 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190054

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java View 1 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
clamy
7 years, 9 months ago (2013-03-20 19:33:14 UTC) #1
nyquist
lgtm with comment https://codereview.chromium.org/12512016/diff/1/sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java File sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java (right): https://codereview.chromium.org/12512016/diff/1/sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java#newcode84 sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java:84: public MockAccountManager(Context context, Context testContext, Account... ...
7 years, 9 months ago (2013-03-20 19:36:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/12512016/5001
7 years, 9 months ago (2013-03-20 23:12:09 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=21967
7 years, 9 months ago (2013-03-21 07:55:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/12512016/5001
7 years, 9 months ago (2013-03-21 14:52:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=22284
7 years, 9 months ago (2013-03-21 18:52:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/12512016/5001
7 years, 9 months ago (2013-03-21 23:28:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/12512016/5001
7 years, 9 months ago (2013-03-22 16:52:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/12512016/5001
7 years, 9 months ago (2013-03-22 18:18:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/12512016/5001
7 years, 9 months ago (2013-03-22 20:08:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/12512016/5001
7 years, 9 months ago (2013-03-23 01:02:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/12512016/5001
7 years, 9 months ago (2013-03-23 14:56:02 UTC) #12
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 18:38:17 UTC) #13
Message was sent while issue was closed. 
Change committed as 190054

Powered by Google App Engine
This is Rietveld 408576698