Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java

Issue 12512016: Fix context problem in Android Sync test utilities (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java
diff --git a/sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java b/sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java
index c92bad763dcd5b711620580333e7346d536e25db..d293918d783ff5b21517b22be4ce37ebd9f39157 100644
--- a/sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java
+++ b/sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java
@@ -12,6 +12,7 @@ import android.accounts.AuthenticatorException;
import android.accounts.OperationCanceledException;
import android.app.Activity;
import android.content.BroadcastReceiver;
+import android.content.ComponentName;
import android.content.Context;
import android.content.Intent;
import android.content.IntentFilter;
@@ -70,6 +71,8 @@ public class MockAccountManager implements AccountManagerDelegate {
protected final Context mContext;
+ private final Context mTestContext;
+
private final Set<AccountHolder> mAccounts;
private final List<AccountAuthTokenPreparation> mAccountPermissionPreparations;
@@ -78,8 +81,11 @@ public class MockAccountManager implements AccountManagerDelegate {
private final SingleThreadedExecutor mExecutor;
- public MockAccountManager(Context context, Account... accounts) {
+ public MockAccountManager(Context context, Context testContext, Account... accounts) {
mContext = context;
+ // The manifest that is backing testContext needs to provide the
+ // MockGrantCredentialsPermissionActivity.
+ mTestContext = testContext;
mMainHandler = new Handler(mContext.getMainLooper());
mExecutor = new SingleThreadedExecutor();
mAccounts = new HashSet<AccountHolder>();
@@ -321,11 +327,11 @@ public class MockAccountManager implements AccountManagerDelegate {
}
}
- private static Intent newGrantCredentialsPermissionIntent(boolean hasActivity, Account account,
+ private Intent newGrantCredentialsPermissionIntent(boolean hasActivity, Account account,
String authTokenType) {
Intent intent = new Intent();
- intent.setClassName("org.chromium.sync.test.util",
- MockGrantCredentialsPermissionActivity.class.getCanonicalName());
+ intent.setComponent(new ComponentName(mTestContext,
+ MockGrantCredentialsPermissionActivity.class.getCanonicalName()));
intent.putExtra(MockGrantCredentialsPermissionActivity.ACCOUNT, account);
intent.putExtra(MockGrantCredentialsPermissionActivity.AUTH_TOKEN_TYPE, authTokenType);
if (!hasActivity) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698