CrOS: Update Chromite recipe module.

CrOS: Update Chromite recipe module.

- Use for property-based default config.
- Support legacy Chromite branches/layouts.
- Move Chromite config name into config, instead of explicit property.

BUG=chromium:468178
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296196

[dnj, 2015-07-31 18:06:11]

dnj@chromium.org changed reviewers:
+ bhthompson@chromium.org, luqui@chromium.org

[dnj, 2015-07-31 18:06:11]

luqui: PTAL
bhthompson: FYI, also PTAL if you're interested :)

[luqui, 2015-07-31 19:58:16]

lgtm % a few things

https://codereview.chromium.org/1250393003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromite/api.py (right):

https://codereview.chromium.org/1250393003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/api.py:27: # zero, it's passed as an empty
string in the properties JSON blob.
The purpose of this comment is unclear.  So this line is a bug workaround?  File
a crbug and link it if so.

https://codereview.chromium.org/1250393003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/api.py:166: def old_chromite_layout(self):
How about using_old_chromite_layout.  This naming makes me think that it returns
the layout (which I know is nonsense, still confused me though)

https://codereview.chromium.org/1250393003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/api.py:187: bindir = ('bin' if not
self.old_chromite_layout else 'buildbot')
This is convoluted to read.  I see what you're going for though, 'bin' is like
the usual one, 'buildbot' is the strange off-case.  Maybe

   bindir = 'bin'
   if self.old_chromite_layout:
       bindir = 'buildbot'

[dnj (Google), 2015-08-01 01:31:33]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2015-08-01 01:31:34]

https://codereview.chromium.org/1250393003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromite/api.py (right):

https://codereview.chromium.org/1250393003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/api.py:27: # zero, it's passed as an empty
string in the properties JSON blob.
On 2015/07/31 19:58:15, luqui wrote:
> The purpose of this comment is unclear.  So this line is a bug workaround? 
File
> a crbug and link it if so.

Filed https://code.google.com/p/chromium/issues/detail?id=516091

Rather than link, I'm going to just fix this bug:
https://codereview.chromium.org/1254003005

https://codereview.chromium.org/1250393003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/api.py:166: def old_chromite_layout(self):
On 2015/07/31 19:58:15, luqui wrote:
> How about using_old_chromite_layout.  This naming makes me think that it
returns
> the layout (which I know is nonsense, still confused me though)

Done.

https://codereview.chromium.org/1250393003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/api.py:187: bindir = ('bin' if not
self.old_chromite_layout else 'buildbot')
On 2015/07/31 19:58:15, luqui wrote:
> This is convoluted to read.  I see what you're going for though, 'bin' is like
> the usual one, 'buildbot' is the strange off-case.  Maybe
> 
>    bindir = 'bin'
>    if self.old_chromite_layout:
>        bindir = 'buildbot'

Agreed this is more readable. Stylistically I like this better too, so Done!

[dnj (Google), 2015-08-03 16:08:44]

The CQ bit was checked by dnj@google.com

[dnj (Google), 2015-08-03 16:08:45]

The patchset sent to the CQ was uploaded after l-g-t-m from luqui@chromium.org
Link to the patchset: https://codereview.chromium.org/1250393003/#ps60001
(title: "Re-added assertion, buildnumber optional again.")

[commit-bot: I haz the power, 2015-08-03 16:08:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1250393003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1250393003/60001

[dnj (Google), 2015-08-03 16:15:04]

The CQ bit was checked by dnj@google.com

[dnj (Google), 2015-08-03 16:15:04]

The patchset sent to the CQ was uploaded after l-g-t-m from luqui@chromium.org
Link to the patchset: https://codereview.chromium.org/1250393003/#ps80001
(title: "Fix coverage.")

[commit-bot: I haz the power, 2015-08-03 16:15:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1250393003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1250393003/80001

[commit-bot: I haz the power, 2015-08-03 16:19:42]

Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296196