Disable Pepper Flash component updater on Linux.

Disable Pepper Flash component updater on Linux.

BUG=174044
Test=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190051

[yzshen1, 2013-03-18 20:49:38]

Hi, Carlos.

Would you please take a look? Thanks!

[cpu_(ooo_6.6-7.5), 2013-03-19 00:54:17]

https://codereview.chromium.org/12494029/diff/1/chrome/browser/component_upda...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

https://codereview.chromium.org/12494029/diff/1/chrome/browser/component_upda...
chrome/browser/component_updater/pepper_flash_component_installer.cc:387: #if
defined(GOOGLE_CHROME_BUILD) && !defined(OS_LINUX)
I think you only need to ifdef this function. Do you need the other ones too?

[yzshen1, 2013-03-19 16:27:08]

https://codereview.chromium.org/12494029/diff/1/chrome/browser/component_upda...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

https://codereview.chromium.org/12494029/diff/1/chrome/browser/component_upda...
chrome/browser/component_updater/pepper_flash_component_installer.cc:387: #if
defined(GOOGLE_CHROME_BUILD) && !defined(OS_LINUX)
On 2013/03/19 00:54:17, cpu wrote:
> I think you only need to ifdef this function. Do you need the other ones too?

In CL https://chromiumcodereview.appspot.com/10977073
Nico marked the other two places because of -Wunused-function warnings. I think
if I change this but not the other two, we will again get warnings.

[yzshen1, 2013-03-20 20:18:39]

Friendly ping.
On 2013/03/19 16:27:08, yzshen1 wrote:
>
https://codereview.chromium.org/12494029/diff/1/chrome/browser/component_upda...
> File chrome/browser/component_updater/pepper_flash_component_installer.cc
> (right):
> 
>
https://codereview.chromium.org/12494029/diff/1/chrome/browser/component_upda...
> chrome/browser/component_updater/pepper_flash_component_installer.cc:387: #if
> defined(GOOGLE_CHROME_BUILD) && !defined(OS_LINUX)
> On 2013/03/19 00:54:17, cpu wrote:
> > I think you only need to ifdef this function. Do you need the other ones
too?
> 
> In CL https://chromiumcodereview.appspot.com/10977073
> Nico marked the other two places because of -Wunused-function warnings. I
think
> if I change this but not the other two, we will again get warnings.

[cpu_(ooo_6.6-7.5), 2013-03-21 17:03:48]

lgtm

[commit-bot: I haz the power, 2013-03-22 15:55:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/12494029/1

[commit-bot: I haz the power, 2013-03-22 18:17:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/12494029/1

[commit-bot: I haz the power, 2013-03-23 14:54:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/12494029/1

[commit-bot: I haz the power, 2013-03-23 18:24:29]

Change committed as 190051