Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10977073: Delete some unused code found by -Wunused-function (Closed)

Created:
8 years, 2 months ago by Nico
Modified:
8 years, 2 months ago
CC:
chromium-reviews, MAD, jam, kkania, amit, dcheng, ajwong+watch_chromium.org, markusheintz_, Ilya Sherman, sergeyu+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, jar (doing other things), kinuko+watch, achuith+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, tzik+watch_chromium.org, erikwright+watch_chromium.org, tim (not reviewing), dbeam+watch-ntp_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, wez+watch_chromium.org, Raghu Simha, sanjeevr, jianli, simonmorris+watch_chromium.org, rmsousa+watch_chromium.org, pam+watch_chromium.org, haitaol1, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, mihaip-chromium-reviews_chromium.org, akalin, tfarina, Dmitry Titov, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, robertshield, rdsmith+dwatch_chromium.org, estade+watch_chromium.org, alexeypa+watch_chromium.org
Visibility:
Public.

Description

Delete some unused code found by -Wunused-function BUG=none,100309 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159592

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : tweak, rebase #

Total comments: 14

Patch Set 4 : leiz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -594 lines) Patch
M base/bind_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_action_apitest.cc View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 2 3 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/extensions/settings/settings_sync_unittest.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/gdata_util_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer_list.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc View 2 chunks +0 lines, -87 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/gpu_internals_ui.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 3 3 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/value_store/value_store_unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/webdata/keyword_table.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 3 chunks +9 lines, -18 lines 0 comments Download
M chrome/common/pepper_flash.cc View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 3 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/gesture_event_filter.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/gpu/gpu_main.cc View 4 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_bindings.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/pepper/pepper_url_request_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/base/net_util.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/base/x509_util_nss.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/base/x509_util_nss_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ppapi/proxy/ppp_content_decryptor_private_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ppapi/thunk/ppb_view_thunk.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M remoting/jingle_glue/xmpp_signal_strategy.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M remoting/protocol/util.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/layout.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gfx/codec/jpeg_codec.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M webkit/fileapi/local_file_system_operation_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 3 chunks +0 lines, -104 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Nico
willchan: base, net thestig: chrome avi: content viettrungluu: ppapi wez: remoting akalin: sync tony: webkit
8 years, 2 months ago (2012-09-28 05:20:22 UTC) #1
Nico
(53 files changed, 55 insertions(+), 576 deletions(-))
8 years, 2 months ago (2012-09-28 05:21:51 UTC) #2
willchan no longer on Chromium
lgtm
8 years, 2 months ago (2012-09-28 05:22:10 UTC) #3
akalin
sync lgtm
8 years, 2 months ago (2012-09-28 05:22:32 UTC) #4
Scott Hess - ex-Googler
https://codereview.chromium.org/10977073/diff/6002/chrome/common/pepper_flash.cc File chrome/common/pepper_flash.cc (right): https://codereview.chromium.org/10977073/diff/6002/chrome/common/pepper_flash.cc#newcode12 chrome/common/pepper_flash.cc:12: #elif defined(OS_MACOSX) MOAR DELETING CODE HERE PLEASE. Or not. ...
8 years, 2 months ago (2012-09-28 05:31:33 UTC) #5
Nico
https://codereview.chromium.org/10977073/diff/6002/chrome/common/pepper_flash.cc File chrome/common/pepper_flash.cc (right): https://codereview.chromium.org/10977073/diff/6002/chrome/common/pepper_flash.cc#newcode10 chrome/common/pepper_flash.cc:10: #if defined(OS_WIN) || defined(OS_MACOSX) Err. Reverted this part :-P
8 years, 2 months ago (2012-09-28 05:35:12 UTC) #6
Avi (use Gerrit)
Yes, thank you please. LGTM
8 years, 2 months ago (2012-09-28 13:25:41 UTC) #7
Wez
https://codereview.chromium.org/10977073/diff/9003/remoting/jingle_glue/xmpp_signal_strategy.cc File remoting/jingle_glue/xmpp_signal_strategy.cc (left): https://codereview.chromium.org/10977073/diff/9003/remoting/jingle_glue/xmpp_signal_strategy.cc#oldcode41 remoting/jingle_glue/xmpp_signal_strategy.cc:41: } // namespace We want these constants to be ...
8 years, 2 months ago (2012-09-28 17:56:49 UTC) #8
Nico
https://codereview.chromium.org/10977073/diff/9003/remoting/jingle_glue/xmpp_signal_strategy.cc File remoting/jingle_glue/xmpp_signal_strategy.cc (left): https://codereview.chromium.org/10977073/diff/9003/remoting/jingle_glue/xmpp_signal_strategy.cc#oldcode41 remoting/jingle_glue/xmpp_signal_strategy.cc:41: } // namespace On 2012/09/28 17:56:50, Wez wrote: > ...
8 years, 2 months ago (2012-09-28 17:59:36 UTC) #9
Wez
On 2012/09/28 17:59:36, Nico wrote: > https://codereview.chromium.org/10977073/diff/9003/remoting/jingle_glue/xmpp_signal_strategy.cc > File remoting/jingle_glue/xmpp_signal_strategy.cc (left): > > https://codereview.chromium.org/10977073/diff/9003/remoting/jingle_glue/xmpp_signal_strategy.cc#oldcode41 > ...
8 years, 2 months ago (2012-09-28 18:01:56 UTC) #10
Lei Zhang
https://codereview.chromium.org/10977073/diff/9003/chrome/browser/extensions/api/extension_action/page_action_apitest.cc File chrome/browser/extensions/api/extension_action/page_action_apitest.cc (right): https://codereview.chromium.org/10977073/diff/9003/chrome/browser/extensions/api/extension_action/page_action_apitest.cc#newcode21 chrome/browser/extensions/api/extension_action/page_action_apitest.cc:21: #include "ui/gfx/image/image_skia.h" you can also remove the skia header. ...
8 years, 2 months ago (2012-09-28 18:41:23 UTC) #11
tony
webkit LGTM
8 years, 2 months ago (2012-09-28 19:10:05 UTC) #12
Nico
Thanks! https://codereview.chromium.org/10977073/diff/9003/chrome/browser/extensions/api/extension_action/page_action_apitest.cc File chrome/browser/extensions/api/extension_action/page_action_apitest.cc (right): https://codereview.chromium.org/10977073/diff/9003/chrome/browser/extensions/api/extension_action/page_action_apitest.cc#newcode21 chrome/browser/extensions/api/extension_action/page_action_apitest.cc:21: #include "ui/gfx/image/image_skia.h" On 2012/09/28 18:41:24, Lei Zhang wrote: ...
8 years, 2 months ago (2012-09-29 11:08:39 UTC) #13
Lei Zhang
lgtm https://codereview.chromium.org/10977073/diff/9003/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc File chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc (left): https://codereview.chromium.org/10977073/diff/9003/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc#oldcode156 chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc:156: #if 0 On 2012/09/29 11:08:40, Nico wrote: > ...
8 years, 2 months ago (2012-10-01 17:31:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10977073/16001
8 years, 2 months ago (2012-10-01 21:22:35 UTC) #15
commit-bot: I haz the power
Presubmit check for 10977073-16001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-01 21:23:06 UTC) #16
viettrungluu
lgtm
8 years, 2 months ago (2012-10-01 21:30:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10977073/16001
8 years, 2 months ago (2012-10-01 21:36:13 UTC) #18
commit-bot: I haz the power
8 years, 2 months ago (2012-10-01 23:54:50 UTC) #19 
Change committed as 159592

Powered by Google App Engine
This is Rietveld 408576698