Issue 12494028: Move Requirements out of Extension Class

Issue 12494028: Move Requirements out of Extension Class (Closed)

Created:
7 years, 9 months ago by Devlin

Modified:
7 years, 9 months ago

Reviewers:
Yoyo Zhou, Pam (message me for reviews), Miranda Callahan, Ben Goodger (Google)

CC:
chromium-reviews, cbentzel+watch_chromium.org, vsevik, gavinp+prer_chromium.org, benjhayden+dwatch_chromium.org, tburkard+watch_chromium.org, yurys, Aaron Boodman, dominich+watch_chromium.org, pam+watch_chromium.org, mmenke, rdsmith+dwatch_chromium.org, sail+watch_chromium.org, chromium-apps-reviews_chromium.org, pfeldman

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move Requirements out of Extension Class TBR=ben@chromium.org, mirandac@chromium.org, pam@chromium.org (ben - gypis, mirandac - profiles, pam - managed_mode) BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190570

Patch Set 1 : #

Total comments: 3

Patch Set 2 : (un)Updated browsertests #

Patch Set 3 : Move Requirements from API #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+274 lines, -264 lines)			Patch
M	chrome/browser/extensions/api/downloads/downloads_api_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	chrome/browser/extensions/chrome_manifest_parser.h	View	1 2	3 chunks	+11 lines, -11 lines	0 comments	Download
A +	chrome/browser/extensions/chrome_manifest_parser.cc	View	1 2	3 chunks	+13 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_service_unittest.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
D	chrome/browser/extensions/manifest_url_parser.h	View	1 2	1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/extensions/manifest_url_parser.cc	View	1 2	1 chunk	+0 lines, -60 lines	0 comments	Download
M	chrome/browser/extensions/requirements_checker.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/managed_mode/managed_user_service_unittest.cc	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_dependency_manager.cc	View	1 2	4 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 2	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 2	4 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 2	3 chunks	+0 lines, -85 lines	0 comments	Download
A	chrome/common/extensions/manifest_handlers/requirements_handler.h	View	1 2	1 chunk	+49 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/manifest_handlers/requirements_handler.cc	View	1 2	1 chunk	+140 lines, -0 lines	0 comments	Download
D	chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc	View	1 2	2 chunks	+38 lines, -26 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

I'm not sure how many of the random cleanups to browsertest files are going to ...

7 years, 9 months ago (2013-03-20 22:41:36 UTC) #2

Devlin

https://codereview.chromium.org/12494028/diff/7001/chrome/browser/devtools/devtools_sanity_browsertest.cc File chrome/browser/devtools/devtools_sanity_browsertest.cc (right): https://codereview.chromium.org/12494028/diff/7001/chrome/browser/devtools/devtools_sanity_browsertest.cc#newcode199 chrome/browser/devtools/devtools_sanity_browsertest.cc:199: (new extensions::RequirementsHandler)->Register(); On 2013/03/20 22:41:36, Yoyo Zhou wrote: > ...

7 years, 9 months ago (2013-03-23 22:28:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/12494028/22001

7 years, 9 months ago (2013-03-25 20:55:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/12494028/22001

7 years, 9 months ago (2013-03-26 06:51:02 UTC) #6

Message was sent while issue was closed.

Change committed as 190570

Expand Messages | Collapse Messages