Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/common/extensions/extension.h

Issue 12494028: Move Requirements out of Extension Class (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Move Requirements from API Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 4daea8f6a21613dbd7166aa4e5888b8fb757694d..6fc1165cb7e920ddf21d0f58e4b1197c80578772 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -104,16 +104,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
SYNC_TYPE_APP
};
- // Declared requirements for the extension.
- struct Requirements {
- Requirements();
- ~Requirements();
-
- bool webgl;
- bool css3d;
- bool npapi;
- };
-
// An NaCl module included in the extension.
struct NaClModuleInfo {
GURL url;
@@ -409,7 +399,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Accessors:
- const Requirements& requirements() const { return requirements_; }
const base::FilePath& path() const { return path_; }
const GURL& url() const { return extension_url_; }
Manifest::Location location() const;
@@ -569,8 +558,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadManifestVersion(string16* error);
bool LoadNaClModules(string16* error);
bool LoadSandboxedPages(string16* error);
- // Must be called after the "plugins" key has been parsed.
- bool LoadRequirements(string16* error);
bool LoadKioskEnabled(string16* error);
bool LoadOfflineEnabled(string16* error);
bool LoadTextToSpeechVoices(string16* error);
@@ -625,9 +612,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// the case when we know the manifest version actually is 1.
int manifest_version_;
- // The requirements declared in the manifest.
- Requirements requirements_;
-
// The absolute path to the directory the extension is stored in.
base::FilePath path_;
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698