Issue 12485012: Clean up InjectDetails param of webview.executeScript json schema.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12485012: Clean up InjectDetails param of webview.executeScript json schema. (Closed)

Created:
7 years, 9 months ago by lazyboy

Modified:
7 years, 9 months ago

Reviewers:
Fady Samuel, not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Clean up InjectDetails param of webview.executeScript json schema. BUG=171726 TEST=WebViewTest.Shim.webViewExecuteScript still passes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190459

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -22 lines)			Patch
	M	chrome/browser/extensions/api/webview/webview_api.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/common/extensions/api/webview.json	View	1	2 chunks	+1 line, -22 lines	0 comments	Download

Total messages: 6 (0 generated)

lazyboy

+kalman for Review. Also, I just noticed comment on crrev.com/11953121, WebViewTest.Shim seems to pass for ...

7 years, 9 months ago (2013-03-25 16:03:43 UTC) #3

not at google - send to devlin

lgtm Ah yes, we fixed this a couple of days ago. Nice!

7 years, 9 months ago (2013-03-25 16:05:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/12485012/4001

7 years, 9 months ago (2013-03-25 16:07:48 UTC) #5

Message was sent while issue was closed.

Change committed as 190459