Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6926)

Unified Diff: chrome/common/extensions/api/webview.json

Issue 12485012: Clean up InjectDetails param of webview.executeScript json schema. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/webview/webview_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/webview.json
diff --git a/chrome/common/extensions/api/webview.json b/chrome/common/extensions/api/webview.json
index 2c52ee646e4c651661341e3064cb5d7f899f4ca5..65a6ac16a112e0339a7fc97d2c8f14a9fac87712 100644
--- a/chrome/common/extensions/api/webview.json
+++ b/chrome/common/extensions/api/webview.json
@@ -6,27 +6,6 @@
{
"namespace": "webview",
"nodoc": true,
- "types": [
- // TODO(fsamuel): We should be usng tabs.InjectDetails. However, due to a
- // bug in the JSON compiler, we are currently copying-and-pasting this
- // type: https://crbug.com/171726.
- {
- "id": "InjectDetails",
- "type": "object",
- "description": "Details of the script or CSS to inject. Either the code or the file property must be set, but both may not be set at the same time.",
- "properties": {
- "code": {"type": "string", "optional": true, "description": "JavaScript or CSS code to inject."},
- "file": {"type": "string", "optional": true, "description": "JavaScript or CSS file to inject."},
- "allFrames": {"type": "boolean", "optional": true, "description": "If allFrames is <code>true</code>, implies that the JavaScript or CSS should be injected into all frames of current page. By default, it's <code>false</code> and will only be injected into the top frame."},
- "runAt": {
- "type": "string",
- "optional": true,
- "enum": ["document_start", "document_end", "document_idle"],
- "description": "The soonest that the JavaScript or CSS will be injected into the tab. Defaults to \"document_idle\"."
- }
- }
- }
- ],
"functions": [
{
"name": "executeScript",
@@ -44,7 +23,7 @@
"description": "The route ID of the guest <webview> renderer."
},
{
- "$ref": "webview.InjectDetails",
+ "$ref": "tabs.InjectDetails",
"name": "details",
"description": "Details of the script to run."
},
« no previous file with comments | « chrome/browser/extensions/api/webview/webview_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698