Issue 12481008: Remove cross-repo OVERRIDE annotations and IWYU-ify comp bindings

Issue 12481008: Remove cross-repo OVERRIDE annotations and IWYU-ify comp bindings (Closed)

Created:
7 years, 9 months ago by jamesr

Modified:
7 years, 9 months ago

Reviewers:
enne (OOO)

CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove cross-repo OVERRIDE annotations and IWYU-ify comp bindings This removes OVERRIDE annotations for implementations of functions declared in WebKit from webkit/compositor_bindings/ and includes / forward declares all types used. Without this, it's impossible to refactor these interface R=enne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186580

Patch Set 1 #

Patch Set 2 : fix w_t_ops_impl.h #

Patch Set 3 : fix forward decl in web_float_animation_curve_impl.h #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -134 lines)			Patch
M	webkit/compositor_bindings/web_animation_impl.h	View		2 chunks	+11 lines, -10 lines	0 comments	Download
M	webkit/compositor_bindings/web_content_layer_impl.h	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	webkit/compositor_bindings/web_external_texture_layer_impl.h	View		2 chunks	+9 lines, -8 lines	0 comments	Download
M	webkit/compositor_bindings/web_float_animation_curve_impl.h	View	1 2	2 chunks	+6 lines, -5 lines	0 comments	Download
M	webkit/compositor_bindings/web_image_layer_impl.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/compositor_bindings/web_io_surface_layer_impl.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/compositor_bindings/web_layer_impl.h	View		3 chunks	+72 lines, -59 lines	0 comments	Download
M	webkit/compositor_bindings/web_layer_impl_fixed_bounds.h	View		1 chunk	+10 lines, -10 lines	0 comments	Download
M	webkit/compositor_bindings/web_scrollbar_layer_impl.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	webkit/compositor_bindings/web_solid_color_layer_impl.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/compositor_bindings/web_to_ccinput_handler_adapter.cc	View		2 chunks	+8 lines, -10 lines	0 comments	Download
M	webkit/compositor_bindings/web_transform_animation_curve_impl.h	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	webkit/compositor_bindings/web_transform_operations_impl.h	View	1	2 chunks	+11 lines, -11 lines	0 comments	Download
M	webkit/compositor_bindings/web_video_layer_impl.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

This patch (should) do nothing, but it's a prereq to removing WebTransformationMatrix from the WebLayer ...

7 years, 9 months ago (2013-03-06 02:44:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12481008/6001

7 years, 9 months ago (2013-03-06 23:04:14 UTC) #3

Message was sent while issue was closed.

Change committed as 186580

Expand Messages | Collapse Messages