Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 12475013: bookmarks: Extract PerformBookmarkDrop() function out of bookmark_utils.h (Closed)

Created:
7 years, 9 months ago by tfarina
Modified:
7 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, sail+watch_chromium.org, Aaron Boodman, dcheng, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

bookmarks: Extract PerformBookmarkDrop() function out of bookmark_utils.h We do a couple of things in this patch: - Move PerformBookmarkDrop() function into c/b/ui/bookmarks/bookmark_drag_drop - Rename to DropBookmarks, so it pairs with DragBookmarks - Along the way platform specific files had to be renamed to not conflict with the new cross-platform bookmark_drag_drop.cc file added. BUG=144783 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188824

Patch Set 1 : #

Patch Set 2 : chromeos fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -483 lines) Patch
M chrome/browser/bookmarks/bookmark_utils.h View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_drag_drop.h View 2 chunks +8 lines, -0 lines 0 comments Download
A chrome/browser/ui/bookmarks/bookmark_drag_drop.cc View 1 chunk +38 lines, -0 lines 0 comments Download
D chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm View 1 chunk +0 lines, -186 lines 0 comments Download
A + chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
D chrome/browser/ui/gtk/bookmarks/bookmark_drag_drop.cc View 1 chunk +0 lines, -19 lines 0 comments Download
A + chrome/browser/ui/gtk/bookmarks/bookmark_drag_drop_gtk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/ui/views/bookmarks/bookmark_drag_drop.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/ui/views/bookmarks/bookmark_drag_drop.cc View 1 chunk +0 lines, -133 lines 0 comments Download
A + chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Scott, the file renames here were due to this error: static library /home/tfarina/chromium/src/chrome/chrome.gyp:browser_ui#target has several ...
7 years, 9 months ago (2013-03-15 23:25:41 UTC) #1
sky
LGTM
7 years, 9 months ago (2013-03-18 15:52:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12475013/7001
7 years, 9 months ago (2013-03-18 18:42:03 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-18 21:21:32 UTC) #4
Message was sent while issue was closed.
Change committed as 188824

Powered by Google App Engine
This is Rietveld 408576698