Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 12475013: bookmarks: Extract PerformBookmarkDrop() function out of bookmark_utils.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: chromeos fixes Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h" 5 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "base/i18n/rtl.h" 13 #include "base/i18n/rtl.h"
14 #include "base/metrics/histogram.h" 14 #include "base/metrics/histogram.h"
15 #include "base/prefs/pref_service.h" 15 #include "base/prefs/pref_service.h"
16 #include "base/string_util.h" 16 #include "base/string_util.h"
17 #include "base/utf_string_conversions.h" 17 #include "base/utf_string_conversions.h"
18 #include "chrome/browser/bookmarks/bookmark_model.h" 18 #include "chrome/browser/bookmarks/bookmark_model.h"
19 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 19 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
20 #include "chrome/browser/bookmarks/bookmark_utils.h" 20 #include "chrome/browser/bookmarks/bookmark_utils.h"
21 #include "chrome/browser/browser_shutdown.h" 21 #include "chrome/browser/browser_shutdown.h"
22 #include "chrome/browser/defaults.h" 22 #include "chrome/browser/defaults.h"
23 #include "chrome/browser/extensions/extension_service.h" 23 #include "chrome/browser/extensions/extension_service.h"
24 #include "chrome/browser/instant/search.h" 24 #include "chrome/browser/instant/search.h"
25 #include "chrome/browser/profiles/profile.h" 25 #include "chrome/browser/profiles/profile.h"
26 #include "chrome/browser/sync/profile_sync_service.h" 26 #include "chrome/browser/sync/profile_sync_service.h"
27 #include "chrome/browser/sync/profile_sync_service_factory.h" 27 #include "chrome/browser/sync/profile_sync_service_factory.h"
28 #include "chrome/browser/themes/theme_properties.h" 28 #include "chrome/browser/themes/theme_properties.h"
29 #include "chrome/browser/ui/bookmarks/bookmark_bar_constants.h" 29 #include "chrome/browser/ui/bookmarks/bookmark_bar_constants.h"
30 #include "chrome/browser/ui/bookmarks/bookmark_drag_drop.h"
30 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h" 31 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"
31 #include "chrome/browser/ui/bookmarks/bookmark_utils.h" 32 #include "chrome/browser/ui/bookmarks/bookmark_utils.h"
32 #include "chrome/browser/ui/browser.h" 33 #include "chrome/browser/ui/browser.h"
33 #include "chrome/browser/ui/chrome_pages.h" 34 #include "chrome/browser/ui/chrome_pages.h"
34 #include "chrome/browser/ui/tabs/tab_strip_model.h" 35 #include "chrome/browser/ui/tabs/tab_strip_model.h"
35 #include "chrome/browser/ui/view_ids.h" 36 #include "chrome/browser/ui/view_ids.h"
36 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h" 37 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h"
37 #include "chrome/browser/ui/views/bookmarks/bookmark_context_menu.h" 38 #include "chrome/browser/ui/views/bookmarks/bookmark_context_menu.h"
38 #include "chrome/browser/ui/views/bookmarks/bookmark_drag_drop.h" 39 #include "chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.h"
39 #include "chrome/browser/ui/views/event_utils.h" 40 #include "chrome/browser/ui/views/event_utils.h"
40 #include "chrome/browser/ui/views/frame/browser_view.h" 41 #include "chrome/browser/ui/views/frame/browser_view.h"
41 #include "chrome/browser/ui/views/location_bar/location_bar_view.h" 42 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
42 #include "chrome/browser/ui/webui/ntp/app_launcher_handler.h" 43 #include "chrome/browser/ui/webui/ntp/app_launcher_handler.h"
43 #include "chrome/common/chrome_notification_types.h" 44 #include "chrome/common/chrome_notification_types.h"
44 #include "chrome/common/chrome_switches.h" 45 #include "chrome/common/chrome_switches.h"
45 #include "chrome/common/extensions/extension_constants.h" 46 #include "chrome/common/extensions/extension_constants.h"
46 #include "chrome/common/pref_names.h" 47 #include "chrome/common/pref_names.h"
47 #include "content/public/browser/notification_details.h" 48 #include "content/public/browser/notification_details.h"
48 #include "content/public/browser/notification_source.h" 49 #include "content/public/browser/notification_source.h"
(...skipping 840 matching lines...) Expand 10 before | Expand all | Expand 10 after
889 index = parent_node->child_count(); 890 index = parent_node->child_count();
890 } else if (drop_info_->location.on) { 891 } else if (drop_info_->location.on) {
891 parent_node = root->GetChild(index); 892 parent_node = root->GetChild(index);
892 index = parent_node->child_count(); 893 index = parent_node->child_count();
893 } else { 894 } else {
894 parent_node = root; 895 parent_node = root;
895 } 896 }
896 const BookmarkNodeData data = drop_info_->data; 897 const BookmarkNodeData data = drop_info_->data;
897 DCHECK(data.is_valid()); 898 DCHECK(data.is_valid());
898 drop_info_.reset(); 899 drop_info_.reset();
899 return bookmark_utils::PerformBookmarkDrop(browser_->profile(), data, 900 return chrome::DropBookmarks(browser_->profile(), data, parent_node, index);
900 parent_node, index);
901 } 901 }
902 902
903 void BookmarkBarView::ShowContextMenu(const gfx::Point& p, 903 void BookmarkBarView::ShowContextMenu(const gfx::Point& p,
904 bool is_mouse_gesture) { 904 bool is_mouse_gesture) {
905 ShowContextMenuForView(this, p); 905 ShowContextMenuForView(this, p);
906 } 906 }
907 907
908 void BookmarkBarView::OnThemeChanged() { 908 void BookmarkBarView::OnThemeChanged() {
909 UpdateColors(); 909 UpdateColors();
910 } 910 }
(...skipping 915 matching lines...) Expand 10 before | Expand all | Expand 10 after
1826 browser_->profile()->GetPrefs()->GetBoolean( 1826 browser_->profile()->GetPrefs()->GetBoolean(
1827 prefs::kShowAppsShortcutInBookmarkBar); 1827 prefs::kShowAppsShortcutInBookmarkBar);
1828 } 1828 }
1829 1829
1830 void BookmarkBarView::OnAppsPageShortcutVisibilityChanged() { 1830 void BookmarkBarView::OnAppsPageShortcutVisibilityChanged() {
1831 DCHECK(apps_page_shortcut_); 1831 DCHECK(apps_page_shortcut_);
1832 apps_page_shortcut_->SetVisible(ShouldShowAppsShortcut()); 1832 apps_page_shortcut_->SetVisible(ShouldShowAppsShortcut());
1833 UpdateBookmarksSeparatorVisibility(); 1833 UpdateBookmarksSeparatorVisibility();
1834 Layout(); 1834 Layout();
1835 } 1835 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/bookmarks/bookmark_drag_drop_gtk.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_drag_drop.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698