Issue 12470004: [NaCl SDK] Fix bug in "naclsdk update", updating recommended bundles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12470004: [NaCl SDK] Fix bug in "naclsdk update", updating recommended bundles. (Closed)

Created:
7 years, 9 months ago by binji

Modified:
7 years, 9 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, binji, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Fix bug in "naclsdk update", updating recommended bundles. Running "naclsdk update" should only update bundles that are marked recommended == "yes". Also, the "sdk_tools" bundle is marked as recommended, but should not be added to this list (it is automatically updated). BUG=179648 R=sbc@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186279

Patch Set 1 #

Patch Set 2 : fix tests #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -6 lines)			Patch
	M	native_client_sdk/src/build_tools/sdk_tools/command/update.py	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	native_client_sdk/src/build_tools/tests/sdktools_commands_test.py	View	1	3 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/12470004/5001

7 years, 9 months ago (2013-03-05 23:12:36 UTC) #3

Message was sent while issue was closed.

Change committed as 186279

Expand Messages | Collapse Messages