Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: native_client_sdk/src/build_tools/sdk_tools/command/update.py

Issue 12470004: [NaCl SDK] Fix bug in "naclsdk update", updating recommended bundles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tests Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/tests/sdktools_commands_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/sdk_tools/command/update.py
diff --git a/native_client_sdk/src/build_tools/sdk_tools/command/update.py b/native_client_sdk/src/build_tools/sdk_tools/command/update.py
index 7fa9066cd98cec73355185f58fd8110742817715..3ae4f0d46aed9509bb37b98fc58ad9d1761c5fb7 100644
--- a/native_client_sdk/src/build_tools/sdk_tools/command/update.py
+++ b/native_client_sdk/src/build_tools/sdk_tools/command/update.py
@@ -212,8 +212,11 @@ def _GetRequestedBundleNamesFromArgs(remote_manifest, requested_bundles):
def _GetRecommendedBundleNames(remote_manifest):
- return [bundle.name for bundle in remote_manifest.GetBundles() if
- bundle.recommended]
+ result = []
+ for bundle in remote_manifest.GetBundles():
+ if bundle.recommended == 'yes' and bundle.name != SDK_TOOLS:
+ result.append(bundle.name)
+ return result
def _BundleNeedsUpdate(delegate, local_manifest, bundle):
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/tests/sdktools_commands_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698