Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 12459011: Avoid bool to Oddball conversions by being lazy. (Closed)

Created:
7 years, 9 months ago by Yang
Modified:
7 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Avoid bool to Oddball conversions by being lazy. R=svenpanne@chromium.org BUG=v8:2491 Committed: https://code.google.com/p/v8/source/detail?r=13869

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -73 lines) Patch
M src/api.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M src/ast.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/execution.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects.cc View 7 chunks +19 lines, -35 lines 0 comments Download
M src/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Please take a look.
7 years, 9 months ago (2013-03-07 13:52:17 UTC) #1
Sven Panne
lgtm
7 years, 9 months ago (2013-03-07 14:02:08 UTC) #2
Yang
7 years, 9 months ago (2013-03-07 16:22:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r13869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698