src/ast.h - Issue 12459011: Avoid bool to Oddball conversions by being lazy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.h

Issue 12459011: Avoid bool to Oddball conversions by being lazy. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.h

diff --git a/src/ast.h b/src/ast.h

index 66b4dd46c46fa23d577edb1ef2197ceafcf7d225..05f0653dc98ee4515390634551f5449e6ea0b46f 100644

--- a/src/ast.h

+++ b/src/ast.h

@@ -1183,8 +1183,8 @@ class Literal: public Expression {

return Handle<String>::cast(handle_);

}

- virtual bool ToBooleanIsTrue() { return handle_->ToBoolean()->IsTrue(); }

- virtual bool ToBooleanIsFalse() { return handle_->ToBoolean()->IsFalse(); }

+ virtual bool ToBooleanIsTrue() { return handle_->BooleanValue(); }

+ virtual bool ToBooleanIsFalse() { return !handle_->BooleanValue(); }

// Identity testers.

bool IsNull() const {

« no previous file with comments | « src/api.cc ('k') | src/execution.h » ('j') | no next file with comments »