Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12453011: Move InputMethodManager to chromeos/ime (Closed)

Created:
7 years, 9 months ago by Seigo Nonaka
Modified:
7 years, 9 months ago
Reviewers:
satorux1
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, tfarina, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Move InputMethodManager to chromeos/ime To use IME related stuff in ash/, moving InputMethodManager from chrome/browser/chromeos to chromeos/ime Note that, the actual implementation and instance is still in chrome/browser/chromeos because hard to decouple grit from InputMethodUtil at this moment. BUG=None TEST=try bots

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -673 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/browser_state_monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/browser_state_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/input_method/input_method_config.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_config.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_delegate.h View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/input_method/input_method_descriptor.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_descriptor.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_descriptor_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/input_method/input_method_manager.h View 1 chunk +0 lines, -163 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/input_method/input_method_property.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_property.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_property_unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_whitelist.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mock_ibus_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/language_switch_menu.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_display.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_key_event_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ime_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/chromeos.gyp View 1 2 chunks +9 lines, -0 lines 0 comments Download
A + chromeos/ime/input_method_config.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + chromeos/ime/input_method_config.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/ime/input_method_delegate.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + chromeos/ime/input_method_descriptor.h View 3 chunks +5 lines, -4 lines 0 comments Download
A + chromeos/ime/input_method_descriptor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/ime/input_method_descriptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/ime/input_method_manager.h View 3 chunks +8 lines, -7 lines 0 comments Download
A + chromeos/ime/input_method_property.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + chromeos/ime/input_method_property.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/ime/input_method_property_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Seigo Nonaka
7 years, 9 months ago (2013-03-08 07:36:52 UTC) #1
Seigo Nonaka
ping? just in case.
7 years, 9 months ago (2013-03-12 08:46:56 UTC) #2
Seigo Nonaka
7 years, 9 months ago (2013-03-19 03:36:05 UTC) #3 
Sorry for review cancel after request, but I spitted this issue more
break-downed ones.

Thank you.

Powered by Google App Engine
This is Rietveld 408576698