Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1244143003: Should be tracking scrolls for Outer, and not Inner, scroll layer. (Closed)

Created:
5 years, 5 months ago by wjmaclean
Modified:
5 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Should be tracking scrolls for Outer, and not Inner, Viewport. In https://codereview.chromium.org/1013753014 the trace added to track main-frame scrolling was watching on the wrong viewport layer. This CL fixes it so it watches the OuterViewportLayer instead. BUG=468304 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/3233269d7dd4ff4403f047fd32df0bd97a4f0257 Cr-Commit-Position: refs/heads/master@{#339951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/layers/layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
wjmaclean
One-liner, TRACE fix, please take a look?
5 years, 5 months ago (2015-07-22 18:50:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244143003/1
5 years, 5 months ago (2015-07-22 18:51:00 UTC) #4
enne (OOO)
lgtm
5 years, 5 months ago (2015-07-22 19:00:42 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-22 19:51:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244143003/1
5 years, 5 months ago (2015-07-22 20:35:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 20:48:51 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 20:49:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3233269d7dd4ff4403f047fd32df0bd97a4f0257
Cr-Commit-Position: refs/heads/master@{#339951}

Powered by Google App Engine
This is Rietveld 408576698