cc/layers/layer_impl.cc - Issue 1244143003: Should be tracking scrolls for Outer, and not Inner, scroll layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_impl.cc

Issue 1244143003: Should be tracking scrolls for Outer, and not Inner, scroll layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/layer_impl.cc

diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc

index af3f24a1dfdb789cfe44da1d674981c3e435169e..da8015c8af10f3efcc84c38bd821479e090e2433 100644

--- a/cc/layers/layer_impl.cc

+++ b/cc/layers/layer_impl.cc

@@ -1521,7 +1521,7 @@ void LayerImpl::SetScrollbarPosition(ScrollbarLayerImplBase* scrollbar_layer,

scrollbar_needs_animation |=

scrollbar_layer->SetVisibleToTotalLengthRatio(visible_ratio);

if (y_offset_did_change && layer_tree_impl()->IsActiveTree() &&

- this == layer_tree_impl()->InnerViewportScrollLayer()) {

+ this == layer_tree_impl()->OuterViewportScrollLayer()) {

TRACE_COUNTER_ID1("cc", "scroll_offset_y", this->id(),

current_offset.y());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »