Move remaining Autofill code to //components/autofill.

Move remaining Autofill code to //components/autofill.

This leaves behind all browser tests, the AutofillCCInfobarDelegate
and PersonalDataManagerFactory, which remain Chrome-specific.

All source files were moved using //tools/git/move_source_file.py,
which updates includes of moved files, sorts include order, and
updates header guards.

The only manual bits of this change were:
- Move .proto file
- Move .cc.utf8 file
- Update .gypi files
- Update DEPS files
- Remove an unnecessary include from autofill_manager.cc

TBR=ben@chromium.org
BUG=140037
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187173

[Ilya Sherman, 2013-03-09 00:48:19]

https://codereview.chromium.org/12434004/diff/1/components/autofill.gypi
File components/autofill.gypi (right):

https://codereview.chromium.org/12434004/diff/1/components/autofill.gypi#newc...
components/autofill.gypi:14:
'autofill/browser/autofill_regex_constants.cc.utf8',
Does this path need to be updated?

https://codereview.chromium.org/12434004/diff/1/components/autofill.gypi#newc...
components/autofill.gypi:21:
'autofill/browser/autofill_regex_constants.cc.utf8'],
Ditto

https://codereview.chromium.org/12434004/diff/1/components/autofill.gypi#newc...
components/autofill.gypi:29: 'autofill/browser/risk/proto/fingerprint.proto',
Does this path need to be udpated?

https://codereview.chromium.org/12434004/diff/1/components/autofill.gypi#newc...
components/autofill.gypi:32: 'proto_in_dir': 'autofill/browser/risk/proto',
Ditto.

[Jói, 2013-03-09 01:03:35]

I think those are all correct.  Note that the paths are relative to
//components since the .gypi file is in that directory.

From my workspace, here's where those files are relative to the src/ directory:
components/autofill/browser/autofill_regex_constants.cc.utf8
components/autofill/browser/risk/proto/fingerprint.proto

Cheers,
Jói

On Fri, Mar 8, 2013 at 4:48 PM,  <isherman@chromium.org> wrote:
>
> https://codereview.chromium.org/12434004/diff/1/components/autofill.gypi
> File components/autofill.gypi (right):
>
>
https://codereview.chromium.org/12434004/diff/1/components/autofill.gypi#newc...
> components/autofill.gypi:14:
> 'autofill/browser/autofill_regex_constants.cc.utf8',
> Does this path need to be updated?
>
>
https://codereview.chromium.org/12434004/diff/1/components/autofill.gypi#newc...
> components/autofill.gypi:21:
> 'autofill/browser/autofill_regex_constants.cc.utf8'],
> Ditto
>
>
https://codereview.chromium.org/12434004/diff/1/components/autofill.gypi#newc...
> components/autofill.gypi:29:
> 'autofill/browser/risk/proto/fingerprint.proto',
> Does this path need to be udpated?
>
>
https://codereview.chromium.org/12434004/diff/1/components/autofill.gypi#newc...
> components/autofill.gypi:32: 'proto_in_dir':
> 'autofill/browser/risk/proto',
> Ditto.
>
> https://codereview.chromium.org/12434004/

[Jói, 2013-03-09 01:14:16]

+CC blundell, who asked to be in the loop on this change.

Colin, the plan is for this to land during the weekend.

Cheers,
Jói

[Ilya Sherman, 2013-03-09 01:14:16]

Ok, LGTM then.  Thanks :)

[commit-bot: I haz the power, 2013-03-09 15:58:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/12434004/1

[commit-bot: I haz the power, 2013-03-09 15:59:54]

Failed to apply patch for components/autofill/browser/autofill_common_test.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         components/autofill/browser/autofill_common_test.cc
  Copied chrome/browser/autofill/autofill_common_test.cc ->
components/autofill/browser/autofill_common_test.cc
  patching file components/autofill/browser/autofill_common_test.cc
  Hunk #1 FAILED at 2.
  1 out of 1 hunk FAILED -- saving rejects to file
components/autofill/browser/autofill_common_test.cc.rej

Patch:   NR 
chrome/browser/autofill/autofill_common_test.cc->components/autofill/browser/autofill_common_test.cc
Index: components/autofill/browser/autofill_common_test.cc
diff --git a/chrome/browser/autofill/autofill_common_test.cc
b/components/autofill/browser/autofill_common_test.cc
similarity index 95%
rename from chrome/browser/autofill/autofill_common_test.cc
rename to components/autofill/browser/autofill_common_test.cc
index
f7cdf3b2c6f38f621c255c437152c5e8f0baf301..79fbc438d50b4fea06fef6226e9dd622f8c1a6f3
100644
--- a/chrome/browser/autofill/autofill_common_test.cc
+++ b/components/autofill/browser/autofill_common_test.cc
@@ -2,14 +2,14 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/autofill/autofill_common_test.h"
+#include "components/autofill/browser/autofill_common_test.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/utf_string_conversions.h"
-#include "chrome/browser/autofill/autofill_profile.h"
-#include "chrome/browser/autofill/credit_card.h"
 #include "chrome/browser/password_manager/encryptor.h"
 #include "chrome/browser/profiles/profile.h"
+#include "components/autofill/browser/autofill_profile.h"
+#include "components/autofill/browser/credit_card.h"
 #include "components/autofill/common/autofill_pref_names.h"
 #include "components/autofill/common/form_field_data.h"
 #include "components/user_prefs/user_prefs.h"

[Jói, 2013-03-09 19:27:32]

TBR=ben@chromium.org for a lot of automated include updates.

[commit-bot: I haz the power, 2013-03-09 19:27:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/12434004/58001

[commit-bot: I haz the power, 2013-03-09 19:29:54]

Presubmit check for 12434004-58001 failed and returned exit status 1.

INFO:root:Found 242 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/sync/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/ui/views/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/ui/webui/PRESUBMIT.py

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  components/autofill/browser/autofill_xml_parser.h, line 70, 84 chars \
  components/autofill/browser/crypto/rc4_decryptor.h, line 17, 84 chars \
  components/autofill/browser/wallet/wallet_address.h, line 22, 83 chars

Presubmit checks took 25.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2013-03-09 19:58:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/12434004/59050

[commit-bot: I haz the power, 2013-03-09 22:57:00]

Change committed as 187173