Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: components/autofill/browser/DEPS

Issue 12434004: Move remaining Autofill code to //components/autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix long lines Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/DEPS ('k') | components/autofill/browser/address.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/browser/DEPS
diff --git a/chrome/browser/autofill/DEPS b/components/autofill/browser/DEPS
similarity index 54%
rename from chrome/browser/autofill/DEPS
rename to components/autofill/browser/DEPS
index edf414a2f2a7d604fbafa8a3714444ab72440481..f1032f5f3ab5edf31050be1fc799a5eb4d3b670c 100644
--- a/chrome/browser/autofill/DEPS
+++ b/components/autofill/browser/DEPS
@@ -1,11 +1,11 @@
include_rules = [
- # Autofill is being made into a component (it will end up at
- # //components/autofill and not depend on //chrome), so we have
- # these basic rules followed by temporary exceptions. Please don't
- # add to the list of exceptions!
- "-chrome/browser",
- "-chrome/common",
- "+chrome/browser/autofill",
+ "+content/public/browser",
+ "+crypto/random.h",
+ "+google_apis/google_api_keys.h",
+ "+net",
+ "+third_party/libjingle",
+ "+third_party/libphonenumber", # For phone number i18n.
+ "+webkit/plugins/webplugininfo.h",
# TODO(joi): This is "ok" temporarily (it's just a header file with
# a large enum, and doesn't bring in any other dependencies on
@@ -15,12 +15,7 @@ include_rules = [
# callbacks for each event.
"!chrome/common/chrome_notification_types.h",
- # Permanently-allowed DEPS beyond the standard Browser
- # Components-like DEPS above go here.
- "+third_party/libphonenumber", # For phone number i18n.
-
# TODO(joi, kaiwang): Bring this list to zero.
- "!chrome/browser/api/infobars",
"!chrome/browser/api/webdata",
# TODO(akalin): Remove this dependency.
@@ -28,11 +23,15 @@ include_rules = [
]
specific_include_rules = {
- # TODO(joi, kaiwang): Bring this list to zero.
- #
- # Do not add to the list of temporarily-allowed dependencies below,
- # and please do not introduce more #includes of these files.
'.*_[a-z]*test\.cc': [
+ "+content/public/test",
+
+ # TODO(joi, kaiwang): Bring this list to zero.
+ #
+ # Do not add to the list of temporarily-allowed dependencies below,
+ # and please do not introduce more #includes of these files.
+ "!chrome/browser/autofill/autofill_cc_infobar_delegate.h",
+ "!chrome/browser/autofill/personal_data_manager_factory.h",
"!chrome/browser/api/infobars/confirm_infobar_delegate.h",
"!chrome/browser/api/infobars/infobar_service.h",
"!chrome/browser/password_manager/encryptor.h",
@@ -56,29 +55,6 @@ specific_include_rules = {
"!chrome/common/pref_names.h",
"!chrome/common/render_messages.h",
"!chrome/common/url_constants.h",
- ],
-
- # TODO(joi): These files will stay in chrome/browser/autofill when
- # the rest move to components/autofill. Fix DEPS once that happens.
- 'personal_data_manager_factory\.(h|cc)': [
- "+chrome/browser/api/sync",
- "+chrome/browser/profiles/profile_dependency_manager.h",
- "+chrome/browser/profiles/profile_keyed_service.h",
- "+chrome/browser/profiles/profile_keyed_service_factory.h",
- "+chrome/browser/profiles/profile.h",
- "+chrome/browser/webdata/web_data_service_factory.h",
- ],
-
- 'autofill_cc_infobar_delegate\.(h|cc)': [
- "!chrome/browser/api/infobars/confirm_infobar_delegate.h",
- "!chrome/browser/api/infobars/infobar_service.h",
- ],
-
- # Android uses Chrome's personal data manager (i.e. the
- # PersonalDataManagerService) and doesn't need to restrict itself to the
- # autofill component.
- 'personal_data_manager_android\.cc': [
- "!chrome/browser/browser_process.h",
- "!chrome/browser/profiles/profile_manager.h",
+ "!chrome/test/base",
],
}
« no previous file with comments | « components/autofill/DEPS ('k') | components/autofill/browser/address.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698