Issue 12431011: Avoid retaining the pointer to inspected WebContents in DevToolsWindow

Issue 12431011: Avoid retaining the pointer to inspected WebContents in DevToolsWindow (Closed)

Created:
7 years, 9 months ago by Vladislav Kaznacheev

Modified:
7 years, 9 months ago

Reviewers:
vsevik, yurys, pfeldman

CC:
chromium-reviews, jam, yurys, joi+watch-content_chromium.org, darin-cc_chromium.org, pfeldman, Jeffrey Yasskin

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Avoid retaining the pointer to inspected WebContents in DevToolsWindow This fixes the 'use-after-free' bug. BUG=179580 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187848

Patch Set 2 : Introduced observer #

Patch Set 4 : Fixed null pointer access #

Patch Set 5 : Rebase #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -18 lines)			Patch
M	chrome/browser/devtools/devtools_window.h	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/devtools/devtools_window.cc	View	1 2 3	13 chunks	+42 lines, -17 lines	0 comments	Download
M	content/browser/devtools/render_view_devtools_agent_host.cc	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/12431011/diff/1/chrome/browser/devtools/devtools_window.cc File chrome/browser/devtools/devtools_window.cc (right): https://codereview.chromium.org/12431011/diff/1/chrome/browser/devtools/devtools_window.cc#newcode431 chrome/browser/devtools/devtools_window.cc:431: if (!GetInspectedWebContents()) Consider using local variable for the ...

7 years, 9 months ago (2013-03-07 13:24:49 UTC) #2

vsevik

Please note I have added another usage of this pointer here, you should replace it ...

7 years, 9 months ago (2013-03-07 18:42:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/12431011/19001

7 years, 9 months ago (2013-03-12 11:24:28 UTC) #6

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 9 months ago (2013-03-12 15:54:20 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/12431011/31001

7 years, 9 months ago (2013-03-13 08:53:05 UTC) #8

Message was sent while issue was closed.

Change committed as 187848

Expand Messages | Collapse Messages