Chromium Code Reviews Chromium Code Reviews
Issue
12408028:
cc: Delay start of scrollbar animation setNeedsRedraw. (Closed)
Descriptioncc: Delay start of scrollbar animation setNeedsRedraw.
This adds a 300ms delay triggered at ScrollEnd in order to avoid
beginning the setNeedsRedraw cycle until we really start fading the
scrollbar, in order to improve performance during non-fling scrolls.
Notes:
- I switched to notifying the animator about ScrollBegin/ScrollEnd when
the currently scrolling layer is attached/detached, and suppress fading
until ScrollEnd.
- The scrollUpdate path is still needed for when the scroll position changes
due to e.g. Javascript, but it's a no-op during a scroll gesture.
- I deleted the pinchGesture logic for simplicity, as there's no
reason to treat pinches differently from scrolls.
- I switches cc::Thread to use TimeDelta for its postDelayedTask since
I ran into some bugs with the flooring to milliseconds. I updated the
few other callers.
NOTRY=true
BUG=181417
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188684
Patch Set 1 #Patch Set 2 : Rebase to 187970 and update test #
Total comments: 1
Patch Set 3 : Switch to TimeDelta and rebase to 188233 #Patch Set 4 : Switch to CurrentlyScrollingLayer-based approach and change cc::Thread to use TimeDelta #Patch Set 5 : Move check for scroll in progress to LayerImpl #Patch Set 6 : Add another unit test #Patch Set 7 : Add more test expectations #
Total comments: 4
Patch Set 8 : git log #Patch Set 9 : Rebase to 188682 #
Messages
Total messages: 7 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
