Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: ui/touch_selection/touch_selection_controller.cc

Issue 1239583003: Update touch selection notification names, add ESTABLISHED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed changes to tests that are independent of the instertion notification. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/touch_selection/touch_selection_controller.cc
diff --git a/ui/touch_selection/touch_selection_controller.cc b/ui/touch_selection/touch_selection_controller.cc
index ea5db91a766055c25968c6ea1f9eec101dc2fe66..e93bc089e1abf119ea3aac4e4d4a81ea8fe7500f 100644
--- a/ui/touch_selection/touch_selection_controller.cc
+++ b/ui/touch_selection/touch_selection_controller.cc
@@ -132,6 +132,10 @@ void TouchSelectionController::OnSelectionBoundsChanged(
return;
}
+ if (start_orientation_ == TouchHandleOrientation::UNDEFINED) {
jdduke (slow) 2015/07/15 20:33:24 I'm confused, why would we try to activate inserti
Donn Denman 2015/07/15 20:48:03 For a tap-triggered selection there are no handles
+ OnInsertionChanged();
+ }
+
HideAndDisallowShowingAutomatically();
}
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698