Update touch selection notification names, add ESTABLISHED.

ui/touch_selection/touch_selection_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/touch_selection/touch_selection_controller.h"
 
 #include "base/auto_reset.h"
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 
@@ skipping 114 matching lines @@
     OnSelectionChanged();
     return;
   }
 
   if (start_orientation_ == TouchHandleOrientation::CENTER &&
       selection_editable_) {
     OnInsertionChanged();
     return;
   }
 
+  if (start_orientation_ == TouchHandleOrientation::UNDEFINED) {

[jdduke (slow), 2015/07/15 20:33:24]

I'm confused, why would we try to activate insertion if the renderer reports
that there is no insertion point?

[Donn Denman, 2015/07/15 20:48:03]

For a tap-triggered selection there are no handles, so the handle orientation is
undefined.  However, the selection has changed to an insertion, so notification
is important (at least to fix the flaky CS instrumentation tests).  Maybe adding
a comment like the above would help?  Having this notification may allow us to
deprecate the OnSingleTap API too (hoping to check after landing this).

+    OnInsertionChanged();
+  }
+
   HideAndDisallowShowingAutomatically();
 }
 
 bool TouchSelectionController::WillHandleTouchEvent(const MotionEvent& event) {
   if (config_.enable_longpress_drag_selection &&
       longpress_drag_selector_.WillHandleTouchEvent(event)) {
     return true;
   }
 
   if (active_status_ == INSERTION_ACTIVE) {
@@ skipping 443 matching lines @@
     base::TimeDelta duration = base::TimeTicks::Now() - selection_start_time_;
     UMA_HISTOGRAM_CUSTOM_TIMES("Event.TouchSelection.WasDraggedDuration",
                                duration,
                                base::TimeDelta::FromMilliseconds(500),
                                base::TimeDelta::FromSeconds(60),
                                60);
   }
 }
 
 }  // namespace ui